Re: [PATCH] MIDI command line option

2008-09-22 Thread Neil Puttock
Hi Han-Wen, I've uploaded this patch to Rietveld: http://codereview.appspot.com/5692 Is it OK to apply? Regards, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: [PATCH] MIDI command line option

2008-08-30 Thread Neil Puttock
2008/8/30 Han-Wen Nienhuys <[EMAIL PROTECTED]>: > Can you make sure that we this code only once and puts it in a > platform variable? > > (if (eq? platform 'windows) .. ) Done. There are several places where it's duplicated (e.g. ps-to-png.scm, editor.scm), but these are standalone modules. If

Re: [PATCH] MIDI command line option

2008-08-29 Thread Han-Wen Nienhuys
On Fri, Aug 29, 2008 at 8:41 PM, Neil Puttock <[EMAIL PROTECTED]> wrote: > 2008/8/29 Han-Wen Nienhuys <[EMAIL PROTECTED]>: >> well, yeah. You need to insert the proper intelligent code in place >> of 'windows'. > > This works, but does does the same as the code for PLATFORM: > > (midi-extension ,(

Re: [PATCH] MIDI command line option

2008-08-29 Thread Neil Puttock
2008/8/29 Han-Wen Nienhuys <[EMAIL PROTECTED]>: > well, yeah. You need to insert the proper intelligent code in place > of 'windows'. This works, but does does the same as the code for PLATFORM: (midi-extension ,(if (string-ci=? (utsname:sysname (uname)) "windows")

Re: [PATCH] MIDI command line option

2008-08-29 Thread Han-Wen Nienhuys
well, yeah. You need to insert the proper intelligent code in place of 'windows'. On Fri, Aug 29, 2008 at 2:34 PM, Neil Puttock <[EMAIL PROTECTED]> wrote: > 2008/8/28 Han-Wen Nienhuys <[EMAIL PROTECTED]>: > >> Can you change the option init , >> >> >> `(... >>("midi-extension" ,(if windows "

Re: [PATCH] MIDI command line option

2008-08-29 Thread Neil Puttock
2008/8/28 Han-Wen Nienhuys <[EMAIL PROTECTED]>: > Can you change the option init , > > > `(... >("midi-extension" ,(if windows "mid" "midi") "the extension of midi files") >... > ) It breaks compilation; `windows' is an unbound variable. __

Re: [PATCH] MIDI command line option

2008-08-28 Thread Han-Wen Nienhuys
actuallly the code that does the windows specific stuff right now sits in GUB. On Wed, Aug 27, 2008 at 9:08 PM, Neil Puttock <[EMAIL PROTECTED]> wrote: > 2008/8/6 Neil Puttock <[EMAIL PROTECTED]>: >> 2008/8/5 Han-Wen Nienhuys <[EMAIL PROTECTED]>: >>> There is also some code in lily.scm that chec

Re: [PATCH] MIDI command line option

2008-08-27 Thread Neil Puttock
2008/8/6 Neil Puttock <[EMAIL PROTECTED]>: > 2008/8/5 Han-Wen Nienhuys <[EMAIL PROTECTED]>: >> There is also some code in lily.scm that checks for a windows system. >> It's easier to add to there rather than the .nsh > > I've tried setting 'midi-extension here: > > (case PLATFORM > ((windows) >

Re: [PATCH] MIDI command line option

2008-08-06 Thread Neil Puttock
2008/8/5 Han-Wen Nienhuys <[EMAIL PROTECTED]>: > There is also some code in lily.scm that checks for a windows system. > It's easier to add to there rather than the .nsh I've tried setting 'midi-extension here: (case PLATFORM ((windows) ;; change midi default for Windows (ly:set-option 'm

Re: [PATCH] MIDI command line option

2008-08-05 Thread Han-Wen Nienhuys
There is also some code in lily.scm that checks for a windows system. It's easier to add to there rather than the .nsh On Tue, Aug 5, 2008 at 10:35 AM, Mats Bengtsson <[EMAIL PROTECTED]> wrote: > Isn't the answer to Neil's question to be found in the files used to build > the Windows installer. >

Re: [PATCH] MIDI command line option

2008-08-05 Thread Mats Bengtsson
Isn't the answer to Neil's question to be found in the files used to build the Windows installer. In http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=blob;f=nsis/lilypond-prepost.nsh;h=05f6a2e199d1f35bb930c651679f337c28c0f6dc;hb=refs/heads/gub you will see that LilyPond is called using "$INS

Re: [PATCH] MIDI command line option

2008-08-04 Thread Han-Wen Nienhuys
On Mon, Jul 28, 2008 at 4:37 PM, Neil Puttock <[EMAIL PROTECTED]> wrote: > 2008/7/27 Han-Wen Nienhuys <[EMAIL PROTECTED]>: >> Looks good to me. >> >> You may want to change the default for windows. > > I'm not quite sure how to achieve this; if there's a check for windows > which alters the option

Re: [PATCH] MIDI command line option

2008-07-28 Thread Neil Puttock
2008/7/27 Han-Wen Nienhuys <[EMAIL PROTECTED]>: > Looks good to me. > > You may want to change the default for windows. I'm not quite sure how to achieve this; if there's a check for windows which alters the option at runtime, how can a user override this either in a .ly file or using the command

[PATCH] MIDI command line option

2008-07-26 Thread Neil Puttock
Hello, Here's a patch to add a command line option for setting the MIDI extension, as discussed back in May. Regards, Neil From 7ca937e9bbc5c8c44a70fe0a8826244bab93eade Mon Sep 17 00:00:00 2001 From: Neil Puttock <[EMAIL PROTECTED]> Date: Sun, 27 Jul 2008 00:16:04 +0100 Subject: [PATCH] Add midi-