Re: [PATCH] Markup commands \left-brace and \right-brace

2009-07-24 Thread Neil Puttock
2009/7/23 Valentin Villenave v.villen...@gmail.com: do you want me to open a Started page in the tracker to keep track of this patch? Cheers for the offer, but I don't think it's necessary. Once I've dealt with Carl's comments on the latest patch, I think it'll be ready for pushing. Then we

Re: [PATCH] Markup commands \left-brace and \right-brace

2009-07-23 Thread Valentin Villenave
2009/7/15 Neil Puttock n.putt...@gmail.com: A new patch set is available here: http://codereview.appspot.com/8874/show Hi Neil, do you want me to open a Started page in the tracker to keep track of this patch? Regards, Valentin ___ lilypond-devel

Re: [PATCH] Markup commands \left-brace and \right-brace

2009-07-14 Thread Neil Puttock
2009/4/25 Neil Puttock n.putt...@gmail.com: 2009/4/23 Jan Nieuwenhuizen janneke-l...@xs4all.nl: I don't really care about that, but it would be nice to split-out the (find-brace lambda to a generic function. OK, I'll farm it out to lily-library.scm and upload a new patch. A new patch set is

Re: [PATCH] Markup commands \left-brace and \right-brace

2009-04-25 Thread Neil Puttock
2009/4/23 Werner LEMBERG w...@gnu.org: Please review this patch here: http://codereview.appspot.com/8874/show Looks good! I'm not a good lisp programmer, but isn't the standard method for searching like that to not use a loop but recursive calls?  It doesn't really matter, but Han-Wen

Re: [PATCH] Markup commands \left-brace and \right-brace

2009-04-25 Thread Neil Puttock
2009/4/23 Jan Nieuwenhuizen janneke-l...@xs4all.nl: Op donderdag 23-04-2009 om 07:19 uur [tijdzone +0200], schreef Werner LEMBERG: I'm not a good lisp programmer, but isn't the standard method for searching like that to not use a loop but recursive calls? I don't really care about that, but

Re: [PATCH] Markup commands \left-brace and \right-brace

2009-04-25 Thread Neil Puttock
2009/4/24 Mats Bengtsson mats.bengts...@ee.kth.se: I haven't looked at your patch or the implementation, but suddenly remembered about http://lists.gnu.org/archive/html/lilypond-devel/2008-11/msg00405.html which seems to indicate that a binary search was already done. Yes, it's in

Re: [PATCH] Markup commands \left-brace and \right-brace

2009-04-25 Thread Carl D. Sorensen
On 4/25/09 9:43 AM, Neil Puttock n.putt...@gmail.com wrote: 2009/4/23 Jan Nieuwenhuizen janneke-l...@xs4all.nl: Op donderdag 23-04-2009 om 07:19 uur [tijdzone +0200], schreef Werner LEMBERG: I'm not a good lisp programmer, but isn't the standard method for searching like that to not use

Re: [PATCH] Markup commands \left-brace and \right-brace

2009-04-25 Thread Neil Puttock
2009/4/25 Carl D. Sorensen c_soren...@byu.edu: There is a binary search routine for scheme vectors in lily/quote-iterator.cc.  Would it preferable to export that function call and use it? I don't know... is there a way of using such an exported function with other scheme types? Regards, Neil

Re: [PATCH] Markup commands \left-brace and \right-brace

2009-04-23 Thread Jan Nieuwenhuizen
Op donderdag 23-04-2009 om 07:19 uur [tijdzone +0200], schreef Werner LEMBERG: I'm not a good lisp programmer, but isn't the standard method for searching like that to not use a loop but recursive calls? I don't really care about that, but it would be nice to split-out the (find-brace lambda

Re: [PATCH] Markup commands \left-brace and \right-brace

2009-04-23 Thread Carl D. Sorensen
On 4/22/09 11:19 PM, Werner LEMBERG w...@gnu.org wrote: Please review this patch here: http://codereview.appspot.com/8874/show Looks good! I'm not a good lisp programmer, but isn't the standard method for searching like that to not use a loop but recursive calls? It doesn't

Re: [PATCH] Markup commands \left-brace and \right-brace

2009-04-22 Thread Carl Sorensen
Neil Puttock n.puttock at gmail.com writes: Hi, Please review this patch here: http://codereview.appspot.com/8874/show Looks good! Carl ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: [PATCH] Markup commands \left-brace and \right-brace

2009-04-22 Thread Werner LEMBERG
Please review this patch here: http://codereview.appspot.com/8874/show Looks good! I'm not a good lisp programmer, but isn't the standard method for searching like that to not use a loop but recursive calls? It doesn't really matter, but Han-Wen likes to use recursive calls a lot :-)

[PATCH] Markup commands \left-brace and \right-brace

2009-04-19 Thread Neil Puttock
Hi, Please review this patch here: http://codereview.appspot.com/8874/show I've revised the \left-brace command extensively so it uses a binary search to find the closest matching fetaBrace. You might notice that the braces produced are slightly smaller than the equivalent SystemStartBrace