There are a few minor nitpicks remaining with whitespace and
formatting, but I'll sort those out once I've applied the patch.
Hmm, that's bad. Can you tell me more exactly what's happened? I thought
the whitespace issues have gone since I've configured vim to
automatically remove trailing
2009/9/30 Michael Käppler xmichae...@web.de:
Are there still any objections against applying?
I guess not. :)
There are a few minor nitpicks remaining with whitespace and
formatting, but I'll sort those out once I've applied the patch.
Would you mind preparing a patch to document the changes
Are there still any objections against applying?
Regards,
Michael
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
This comment reveals a larger issue than the code it comments, so I
suggest to move it away from lilypond-book.py and rewrite it in Git
commit message and/or an issue on the tracker.
Here you are.
Valentin, can you please open a new issue on the tracker for this?
I suggest the following
2009/9/22 Michael Käppler xmichae...@web.de:
now it's clear to me what happened.
I concatenated the \paper blocks of granados.ly and example-header.ily
together for testing. Because then the fixed line-width from
example-header.ily won't be overwritten by (set-paper-size), it looked as
I've just finished a regtest check and clean docs build, and as far as
I can tell, everything looks fine; there are no warnings reported for
any of the A6-size paper tests, and all the snippets I compared are
virtually indistinguishable.
Wow, unbelievable! Now ready to apply?
2009/9/25 Michael Käppler xmichae...@web.de:
Wow, unbelievable! Now ready to apply?
LGTM, though I'd appreciate it if somebody else could give the patch a
final look (especially the lilypond-book changes, since I'm not that
familiar with it).
Regards,
Neil
Le vendredi 25 septembre 2009 à 23:59 +0100, Neil Puttock a écrit :
LGTM, though I'd appreciate it if somebody else could give the patch a
final look (especially the lilypond-book changes, since I'm not that
familiar with it).
Sure, see below.
--- a/scripts/lilypond-book.py
+++
Hi Neil,
now it's clear to me what happened.
I concatenated the \paper blocks of granados.ly and example-header.ily
together for testing. Because then the fixed line-width from
example-header.ily won't be overwritten by (set-paper-size), it looked
as compressed on master as on my testing
2009/9/20 Michael Käppler xmichae...@web.de:
- your git master compiles without warning and with proper spacing (?,
please proof)
Correct.
I've just done a completely clean build, and it compiles without any
problems (see attached output, which is taken from my local copy of
this page:
Neil Puttock wrote:
2009/9/14 Michael Käppler xmichae...@web.de:
Hmm, I can't reproduce this here. Can you try again and send me an png if it
still fails?
It's still pretty bad; see the attached image.
This is weird. I've just checked out a fresh master, did a make clean
and
2009/9/14 Michael Käppler xmichae...@web.de:
Hmm, I can't reproduce this here. Can you try again and send me an png if it
still fails?
It's still pretty bad; see the attached image.
Regards,
Neil
attachment: granados.preview.png___
lilypond-devel
Hi Neil,
now I know what's the reason. The attempt I made with line-width-cropping
doesn't really work,
since if there are several \paper blocks line-width-cropping affects all and
breaks the other settings.
Ah, I see.
I have to admit the lilypond-book code is very difficult to
Hi Neil,
There are some subtle spacing changes in the docs, but no breakages:
quite often the line width is slightly shorter, resulting in tighter
spacing (see the PNG for expressive-headword.ly attached, which is
eleven pixels shorter than the current example on kainhofer.com).
now I know
2009/9/13 Michael Käppler xmichae...@web.de:
now I know what's the reason. The attempt I made with line-width-cropping
doesn't really work,
since if there are several \paper blocks line-width-cropping affects all and
breaks the other settings.
Ah, I see.
Apart from this, the only other
Neil Puttock wrote Sunday, September 13, 2009 7:45 PM
2009/9/13 Michael Käppler xmichae...@web.de:
Btw. I don't understand, why lilypond-book inserts no line-width
value when
called with fragment.
What is the reason for this behaviour?
I'm not sure, to be honest.
I think
I think lilypond-book inserts line-width only when 'quote' or
'lilyquote' is specified (or 'linewidth' itself, of course).
I don't think so. Look at lilypond-book.py:951. This value preserves if
no option is set. You can verify this by running this small tex file, if
you want:
2009/9/11 Michael Käppler xmichae...@web.de:
...however, I don't really understand the benefit of splitting the regtest.
Do you propose to have separate files for each combination of settings?
It's recommended at the top of the regression testing page.
In your snippet, there's a lot of markup
2009/9/12 Michael Käppler xmichae...@web.de:
Maybe this is the same issue Trevor reported one hour ago?
Unlikely, since a comparison of the snippet files shows they have the
same paper settings.
Regards,
Neil
___
lilypond-devel mailing list
Hi all,
I've just removed some code from page.scm that becomes obsolete through
the patch.
I would be really happy if somebody could test this for regressions. The
problem is that for me it takes more than 12 hours to run a make doc
and for this time I can't do anything other.
(Just to give
2009/9/11 Michael Käppler xmichae...@web.de:
Hi all,
I've just removed some code from page.scm that becomes obsolete through the
patch.
Just a few comments:
Can you rebase your changes in paper-defaults-init.ly so they don't
revert the changes made since your original patch?
The regression
2009/9/11 Neil Puttock n.putt...@gmail.com:
I'm happy to run the tests again. I'll report back once it's completed.
Hmm, not for the first time recently, the regression tests came back
completely unchanged, which should be impossible (nothing to do with
your patch, I think).
There are some
Hi Neil,
I'm fine with all your comments...
The regression test would probably benefit from being split into
several separate tests, particularly the final check-consistency
setting, which can then have #(ly:set-option 'warning-as-error #f)
added to it in anticipation of the mythical time when
There are some subtle spacing changes in the docs, but no breakages:
quite often the line width is slightly shorter, resulting in tighter
spacing (see the PNG for expressive-headword.ly attached, which is
eleven pixels shorter than the current example on kainhofer.com).
Maybe this is the
Hi,
please look again.
Regards,
Michael
From 33c05dd7df4000d7f25d2903e2555d9ca86c2e1f Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Michael=20K=C3=A4ppler?= xmichae...@web.de
Date: Sat, 12 Sep 2009 01:47:00 +0200
Subject: [PATCH] Introduce new handling for paper margin settings.
* Make default
25 matches
Mail list logo
