Re: [PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-28 Thread Kevin Barry
Hi Jonas, > Done (hopefully). Thank you very much; it looks like it worked! Kevin

Re: [PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-28 Thread Jonas Hahnfeld
Am Dienstag, den 28.04.2020, 18:31 +0100 schrieb Kevin Barry: > Hi James, > > > We do have a process, see: > > http://lilypond.org/doc/v2.19/Documentation/contributor-big-page#summary-for-experienced-developers > > > > I have followed this as best I can, but it seems I need to have write >

Re: [PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-28 Thread Kevin Barry
Hi James, > We do have a process, see: > http://lilypond.org/doc/v2.19/Documentation/contributor-big-page#summary-for-experienced-developers I have followed this as best I can, but it seems I need to have write access to the issue tracker before I can send patches. If that is the case then can

Re: [PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-28 Thread James
Hello Kevin, On 27/04/2020 18:07, Kevin Barry wrote: Hi James, Thank you for responding. On Mon, Apr 27, 2020 at 11:09:50AM +0100, James wrote: Is this patch read for full testing or is it work-in-progress you just want someone to comment on it? It's not work in progress no - unless someone

Re: [PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-27 Thread Kevin Barry
Hi James, Thank you for responding. On Mon, Apr 27, 2020 at 11:09:50AM +0100, James wrote: > Is this patch read for full testing or is it work-in-progress you just want > someone to comment on it? It's not work in progress no - unless someone has objections or observations, but I don't mean to

Re: [PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-27 Thread James
Kevin, Is this patch read for full testing or is it work-in-progress you just want someone to comment on it? James On 25/04/2020 08:42, Kevin Barry wrote: Patch is attached to this mail as a file if that is more convenient. Kevin

Re: [PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-25 Thread Kevin Barry
Patch is attached to this mail as a file if that is more convenient. Kevin >From 1c5715ad52139aab936ee7dffb2cdef3d123b369 Mon Sep 17 00:00:00 2001 From: Kevin Barry Date: Fri, 24 Apr 2020 19:26:26 +0100 Subject: [PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend As

[PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-24 Thread Kevin Barry
As there is no routine for determining skylines for utf-8-string stencils, they normally fall back to the grob's bounding box, which is fine. However, when there is a mixture of utf-8-string and other types of stencil (which have associated skyline functions) in a single grob, the entire grob gets