Re: [Patch:] Negative fret numbers cause a warning (issue 1035)

2010-12-24 Thread Marc Hohl
Am 23.12.2010 12:38, schrieb Carl Sorensen: [...] I can see your point here. I suspect that our major reason for disagreeing on this is that you are mostly concerned about tablature, while I'm mostly concerned about fret diagrams. Probably. I must confess that I didn't use fret diagrams very oft

Re: [Patch:] Negative fret numbers cause a warning (issue 1035)

2010-12-23 Thread Carl Sorensen
On 12/23/10 3:27 AM, "Marc Hohl" wrote: > Am 22.12.2010 22:02, schrieb Carl Sorensen: >> >> >> On 12/22/10 4:16 AM, "Marc Hohl" wrote: >> >>> Am 22.12.2010 09:48, schrieb Carl Sorensen: >>> Hmmm - I wrote some tunes with a capo placed at the third fret but covering >>> only strings one upt

Re: [Patch:] Negative fret numbers cause a warning (issue 1035)

2010-12-23 Thread Marc Hohl
Am 22.12.2010 22:02, schrieb Carl Sorensen: On 12/22/10 4:16 AM, "Marc Hohl" wrote: Am 22.12.2010 09:48, schrieb Carl Sorensen: On 12/22/10 1:30 AM, "Marc Hohl" wrote: Hello all, attached is a small patch to handle Issue 1035. Instead of giving an error, it raises a warning when negat

Re: [Patch:] Negative fret numbers cause a warning (issue 1035)

2010-12-22 Thread Carl Sorensen
On 12/22/10 4:16 AM, "Marc Hohl" wrote: > Am 22.12.2010 09:48, schrieb Carl Sorensen: >> On 12/22/10 1:30 AM, "Marc Hohl" wrote: >> >>> Hello all, >>> >>> attached is a small patch to handle Issue 1035. >>> >>> Instead of giving an error, it raises a warning when negative frets >>> are cal

Re: [Patch:] Negative fret numbers cause a warning (issue 1035)

2010-12-22 Thread Marc Hohl
Am 22.12.2010 09:48, schrieb Carl Sorensen: On 12/22/10 1:30 AM, "Marc Hohl" wrote: Hello all, attached is a small patch to handle Issue 1035. Instead of giving an error, it raises a warning when negative frets are calculated in tablature staves or in fret diagrams. Marc, If instead of bei

Re: [Patch:] Negative fret numbers cause a warning (issue 1035)

2010-12-22 Thread Carl Sorensen
On 12/22/10 1:48 AM, "Carl Sorensen" wrote: > I think that's a more robust way to handle it than setting the negative fret > number. Oops, I meant "that's a more robust way to handle it than ignoring the note with the negative fret number." Thanks, Carl _

Re: [Patch:] Negative fret numbers cause a warning (issue 1035)

2010-12-22 Thread Carl Sorensen
On 12/22/10 1:30 AM, "Marc Hohl" wrote: > Hello all, > > attached is a small patch to handle Issue 1035. > > Instead of giving an error, it raises a warning when negative frets > are calculated in tablature staves or in fret diagrams. Marc, If instead of being inside set-fret, this check took

[Patch:] Negative fret numbers cause a warning (issue 1035)

2010-12-22 Thread Marc Hohl
Hello all, attached is a small patch to handle Issue 1035. Instead of giving an error, it raises a warning when negative frets are calculated in tablature staves or in fret diagrams. Regards, Marc From 4a1a80c4be5426e5b4c34beee19656f85aa52ba9 Mon Sep 17 00:00:00 2001 From: Marc Hohl Date: Wed