Re: [XY]-core-extent and general_alignment (issue 2613) (issue 6308093)

2012-06-20 Thread janek . lilypond
Hi, After rereading the code i see that you are totally right! I don't know why i wanted to use dim_cache so much. It's scrapped now. Joe, thanks to your suggestion it is now possible to read extent from any property, including user-defined ones! many thanks, Janek http://codereview.appspot

Re: [XY]-core-extent and general_alignment (issue 2613) (issue 6308093)

2012-06-20 Thread joeneeman
http://codereview.appspot.com/6308093/diff/1/lily/self-alignment-interface.cc File lily/self-alignment-interface.cc (right): http://codereview.appspot.com/6308093/diff/1/lily/self-alignment-interface.cc#newcode206 lily/self-alignment-interface.cc:206: grob_alignment = scm_to_double (scm_cdr (gro

Re: [XY]-core-extent and general_alignment (issue 2613) (issue 6308093)

2012-06-19 Thread k-ohara5a5a
On 2012/06/20 03:20:07, janek wrote: On Wed, Jun 20, 2012 at 1:28 AM, Han-Wen Nienhuys wrote: > It would > be nice if this wouldn't require overhaul of the core data > structures of LilyPond. But it will also help with other things, and i'm pretty sure that a lot

Re: [XY]-core-extent and general_alignment (issue 2613) (issue 6308093)

2012-06-19 Thread Janek WarchoĊ‚
On Wed, Jun 20, 2012 at 1:28 AM, Han-Wen Nienhuys wrote: > This patch seems to be for solving a lyrics related problem. It would > be nice if this wouldn't require overhaul of the core data structures > of LilyPond. Each and every graphic object has a dimension-cache, so > you're adding a core-ext

Re: [XY]-core-extent and general_alignment (issue 2613) (issue 6308093)

2012-06-19 Thread Han-Wen Nienhuys
This patch seems to be for solving a lyrics related problem. It would be nice if this wouldn't require overhaul of the core data structures of LilyPond. Each and every graphic object has a dimension-cache, so you're adding a core-extent (as opposed to the normal extent) to each object. Does that ma

[XY]-core-extent and general_alignment (issue 2613) (issue 6308093)

2012-06-19 Thread janek . lilypond
Reviewers: MikeSol, joeneeman, Message: A pdf showing what this patch does is attached to tracker issue: http://code.google.com/p/lilypond/issues/detail?id=2613#c2 Please review! Description: [XY]-core-extent and general_alignment (issue 2613) This adds a versatile method for specifying alignm