Pal wrote Friday, February 04, 2011 5:11 PM
http://codereview.appspot.com/4126042/diff/3009/scm/modal-transforms.scm#newcode68
scm/modal-transforms.scm:68: (lambda (pivot-pitch pitch)
I'm afraid this is not a good interface, as there are inversions
where
the pivot is between two notes.
e.g.
Changes made in http://codereview.appspot.com/4079064/
- Original Message -
From: n.putt...@gmail.com
Sent: Friday, February 04, 2011 10:24 AM
Subject: Re: Add Modal transformations (issue4126042)
http://codereview.appspot.com/4126042/diff/3009/Documentation/notation/pitches.itely
Changes in http://codereview.appspot.com/4079064/
From: percival.music...@gmail.com
Sent: Friday, February 04, 2011 1:43 AM
Subject: Re: Add Modal transformations (issue4126042)
LGTM. I don't think you need to wait until Sat.
Perhaps I should have waited :(
http://codereview.appspot.com
Thanks. This is good feedback. I agree that an extra argument could
be useful. I think of this operation as transposition followed by
inversion, so Pal's example could be implemented this way:
%%
modalTransposedInversion =
Michael Ellis wrote Saturday, February 05, 2011 4:23 PM
In practice, it will be more efficient to code it as Pal suggests,
with two index operations -- although I have no idea whether the
efficiency gain would be significant in terms of LilyPond's total
processing overhead.
I'm not unhappy
On Wed, Feb 02, 2011 at 07:38:45PM +, Graham Percival wrote:
Let me rephrase / alter my initial suggestion: might it be worth
having some predefined scales for actually well-defined scales?
Like \major or \locrian or the like? They could go in a new
ly/*-init.ly file, or maybe something
http://codereview.appspot.com/4126042/diff/5002/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (right):
http://codereview.appspot.com/4126042/diff/5002/Documentation/notation/pitches.itely#newcode828
Documentation/notation/pitches.itely:828: Lilypond provides
Thanks Keith
http://codereview.appspot.com/4126042/diff/5002/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (right):
http://codereview.appspot.com/4126042/diff/5002/Documentation/notation/pitches.itely#newcode867
Documentation/notation/pitches.itely:867:
Keith wrote Thursday, February 03, 2011 7:22 AM
http://codereview.appspot.com/4126042/diff/5002/ly/music-functions-init.ly#newcode465
ly/music-functions-init.ly:465: modalInversion =
Since it is an operator, should it be a verb, modalInvert ?
The distinction between \transpose and
Thanks James
http://codereview.appspot.com/4126042/diff/5002/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (right):
http://codereview.appspot.com/4126042/diff/5002/Documentation/notation/pitches.itely#newcode828
Documentation/notation/pitches.itely:828:
Graham Percival wrote Wednesday, February 02, 2011 7:38 PM
IIRC, diatonic can refer to any church mode.
Let me rephrase / alter my initial suggestion: might it be worth
having some predefined scales for actually well-defined scales?
Like \major or \locrian or the like? They could go in a
IIRC, diatonic can refer to any church mode.
Let me rephrase / alter my initial suggestion: might it be worth
having some predefined scales for actually well-defined scales?
Like \major or \locrian or the like? They could go in a new
ly/*-init.ly file, or maybe something in scm/. Something
Benkő Pál wrote Thursday, February 03, 2011 3:28 PM
I think for these purposes all church modes are equivalent.
the different minor scales are truly different.
Don't some church modes have an optional flat?
For pentatonic scales there are even more in common use,
I believe. Even the five
I think for these purposes all church modes are equivalent.
the different minor scales are truly different.
Don't some church modes have an optional flat?
that's the concern of musica ficta, no need to handle it here.
For pentatonic scales there are even more in common use,
I believe. Even
LGTM. I don't think you need to wait until Sat.
http://codereview.appspot.com/4126042/diff/3009/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (right):
http://codereview.appspot.com/4126042/diff/3009/Documentation/notation/pitches.itely#newcode840
On Thu, 03 Feb 2011 17:43:38 -0800, percival.music...@gmail.com wrote:
not a patch comment, but I'm intrigued -- how often do you think that
people use automatic ties?
I had never used them or seen them used.
But the moment I started playing with \retrograde, on a melody that did not
fill an
Might it be worth having some predefined scales,
i.e. \diatonicScale and \pentatonicScale and the like?
I don't think so; they are not unique. Even a chromatic scale can be
written using many combinations of naming the enharmonically equivalent
notes. You might argue that a C major scale
On Wed, Feb 02, 2011 at 11:20:22AM +, tdanielsmu...@googlemail.com wrote:
Might it be worth having some predefined scales,
i.e. \diatonicScale and \pentatonicScale and the like?
I don't think so; they are not unique.
I'm not sure what you mean by this. For instance:
\majorScale c is
On Wed, Feb 02, 2011 at 05:55:04PM +, Bernard Hurley wrote:
On Wed, Feb 02, 2011 at 11:20:22AM +, tdanielsmu...@googlemail.com wrote:
Might it be worth having some predefined scales,
i.e. \diatonicScale and \pentatonicScale and the like?
I don't think so; they are not unique.
This works very nicely for me.
One tiny oops, and suggestions you can take or leave as you wish.
I think I understand the point that some scales *can* un-ambiguously
named, but a facility to generate scales from these names is not
necessary for this patch.
I can type
myPentatonic = \relative
First stab at documentation now added. Comments from anyone familiar
with these operations welcome.
Trevor
http://codereview.appspot.com/4126042/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Might it be worth having some predefined scales, i.e. \diatonicScale and
\pentatonicScale and the like?
http://codereview.appspot.com/4126042/diff/4002/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (right):
Reviewers: ,
Message:
The set of modal transforms provided by Mike Ellis are now ready for
review. As the changes are all in Scheme code they are easy to test.
Patch set 1 are as originally provided by Mike; patch set 2 are after
some tidying up by me.
As yet there is no documentation. I'll
23 matches
Mail list logo
