On 2020/02/04 23:40:03, dak wrote:
> Personally, the best of two worlds would be if a ping-pong between our
current
> Astyle and clang-format would end up stable after one application of
each. That
> way, putting the code base through both Astyle and clang-format
semi-regularly
> would put it into
On 2020/02/04 22:18:23, hanwenn wrote:
> On 2020/02/04 20:35:40, Dan Eble wrote:
> > I'm running some of my patches through clang-format as I prepare to
push them.
> >
> > This is an example of a kind of change it wants to make:
> >
> > - const array key {column_rank, dir};
> > + const array ke
On 2020/02/04 20:35:40, Dan Eble wrote:
> I'm running some of my patches through clang-format as I prepare to
push them.
>
> This is an example of a kind of change it wants to make:
>
> - const array key {column_rank, dir};
> + const array key{column_rank, dir};
>
> Note the space after key.
I'm running some of my patches through clang-format as I prepare to push
them.
This is an example of a kind of change it wants to make:
- const array key {column_rank, dir};
+ const array key{column_rank, dir};
Note the space after key. The setting that controls this is
SpaceBeforeCpp11Braced
> If Werner likes it, I'm fine with it.
I do like it, and it is completely non-intrusive since it gets used
locally only for those people who set up a proper git hook (or call
`clang-format` manually).
https://codereview.appspot.com/561340043/
On 2020/01/31 18:06:00, hanwenn wrote:
> Will james pick this up automatically now, or does it need
> an LGTM?
James should pick it up automatically now.
https://codereview.appspot.com/561340043/
On 2020/01/31 18:33:38, Carl wrote:
> IIUC, this is a .clang-format that can be (but is not required to be)
used to
> format source code and prevent comments about formatting.
>
> At this point, we are not enforcing a shift to clang-format as the
code standard
> for LilyPond.
>
> If this is true,
IIUC, this is a .clang-format that can be (but is not required to be)
used to format source code and prevent comments about formatting.
At this point, we are not enforcing a shift to clang-format as the code
standard for LilyPond.
If this is true, LGTM.
If we are enforcing a shift to clang-forma
On 2020/01/31 12:35:45, Dan Eble wrote:
> On 2020/01/31 09:39:33, hanwenn wrote:
> > I've applied your suggestion; PTAL.
>
> If Werner likes it, I'm fine with it. I haven't tried it myself
because I want
> to avoid being drawn into discussing the details of the style, but I
like seeing
> movement
On 2020/01/31 09:39:33, hanwenn wrote:
> I've applied your suggestion; PTAL.
If Werner likes it, I'm fine with it. I haven't tried it myself because
I want to avoid being drawn into discussing the details of the style,
but I like seeing movement toward a better process.
https://codereview.appsp
On 2020/01/29 12:19:54, Dan Eble wrote:
> On 2020/01/29 07:41:40, lemzwerg wrote:
> > The output looks good. BTW, for the sake of Emacs, it would be nice
if two
> > spaces after a full dot could be retained in comments. Does such an
option
> > exist?
>
> Retaining everything with ReflowComments:
On 2020/01/29 07:41:40, lemzwerg wrote:
> The output looks good. BTW, for the sake of Emacs, it would be nice
if two
> spaces after a full dot could be retained in comments. Does such an
option
> exist?
Retaining everything with ReflowComments:false might be the only way.
https://releases.llvm.o
> just the overrides
The new version works just fine. Shall I still inspect the previous
version for problematic statements?
The output looks good. BTW, for the sake of Emacs, it would be nice if
two spaces after a full dot could be retained in comments. Does such an
option exist?
https://cod
Reviewers: lemzwerg,
Message:
On 2020/01/27 10:07:20, lemzwerg wrote:
> For which clang-format version is this format file? It doesn't work
with 7.0.1,
> for example. Please add this information to the file.
$ clang-format --version
clang-format version 9.0.0 (Fedora 9.0.0-1.fc31)
can you pinp
For which clang-format version is this format file? It doesn't work
with 7.0.1, for example. Please add this information to the file.
https://codereview.appspot.com/561340043/
15 matches
Mail list logo
