Re: Add documentation for the music function \alterBroken to the NR. (issue 15060044)

2013-10-19 Thread tdanielsmusic
LGTM Trevor https://codereview.appspot.com/15060044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add documentation for the music function \alterBroken to the NR. (issue 15060044)

2013-10-19 Thread david . nalesnik
On 2013/10/19 17:56:28, t.daniels_treda.co.uk wrote: From: > https://codereview.appspot.com/15060044/diff/1/Documentation/notation/changing-defaults.itely#newcode4396 >> Documentation/notation/changing-defaults.itely:4396: >> Should there be a warning about

Re: Add documentation for the music function \alterBroken to the NR. (issue 15060044)

2013-10-19 Thread david . nalesnik
https://codereview.appspot.com/15060044/diff/350001/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/15060044/diff/350001/Documentation/notation/changing-defaults.itely#newcode4362 Documentation/notation/ch

Re: Add documentation for the music function \alterBroken to the NR. (issue 15060044)

2013-10-19 Thread Trevor Daniels
From: > https://codereview.appspot.com/15060044/diff/1/Documentation/notation/changing-defaults.itely#newcode4396 >> Documentation/notation/changing-defaults.itely:4396: >> Should there be a warning about not using \break >> to enforce line breaks? > > The command will work if the break isn't

Re: Add documentation for the music function \alterBroken to the NR. (issue 15060044)

2013-10-19 Thread janek . lilypond
LGTM except for one comment. https://codereview.appspot.com/15060044/diff/350001/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/15060044/diff/350001/Documentation/notation/changing-defaults.itely#newcode

Re: Add documentation for the music function \alterBroken to the NR. (issue 15060044)

2013-10-19 Thread david . nalesnik
On 2013/10/19 09:50:43, Trevor Daniels wrote: LGTM with a couple of nitpicks and a query (although I haven't tried a make doc to check the appearance of the examples). At first I was a little concerned about the explanations in what is supposed to be a _reference_ manual, but in this case I th

Re: Add documentation for the music function \alterBroken to the NR. (issue 15060044)

2013-10-19 Thread Thomas Morley
2013/10/19 : > On 2013/10/19 09:00:31, janek wrote: >> >> 2013/10/19 : >> > I cannot review _and_ comment inline, when I click on side-by-sdie > > diffs >> >> > I get 'error chunk mismatch'. Does anyone else? > > >> me too. > > > Yes, I also get "error: old chunk mismatch" and this happens to me

Re: Add documentation for the music function \alterBroken to the NR. (issue 15060044)

2013-10-19 Thread david . nalesnik
On 2013/10/19 09:00:31, janek wrote: 2013/10/19 : > I cannot review _and_ comment inline, when I click on side-by-sdie diffs > I get 'error chunk mismatch'. Does anyone else? me too. Yes, I also get "error: old chunk mismatch" and this happens to me when I try to view the side-by-sides of

Re: Add documentation for the music function \alterBroken to the NR. (issue 15060044)

2013-10-19 Thread tdanielsmusic
LGTM with a couple of nitpicks and a query (although I haven't tried a make doc to check the appearance of the examples). At first I was a little concerned about the explanations in what is supposed to be a _reference_ manual, but in this case I think they are justified. They are well-written, n

Re: Add documentation for the music function \alterBroken to the NR. (issue 15060044)

2013-10-19 Thread Janek WarchoĊ‚
2013/10/19 : > I cannot review _and_ comment inline, when I click on side-by-sdie diffs > I get 'error chunk mismatch'. Does anyone else? me too. ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-dev

Re: Add documentation for the music function \alterBroken to the NR. (issue 15060044)

2013-10-19 Thread pkx166h
On 2013/10/18 22:18:44, david.nalesnik wrote: Please review. I cannot review _and_ comment inline, when I click on side-by-sdie diffs I get 'error chunk mismatch'. Does anyone else? https://codereview.appspot.com/15060044/ ___ lilypond-devel mailing

Add documentation for the music function \alterBroken to the NR. (issue 15060044)

2013-10-18 Thread david . nalesnik
Reviewers: , Message: Please review. Description: Add documentation for the music function \alterBroken to the NR. Issue 3458: Document \alterBroken Please review this at https://codereview.appspot.com/15060044/ Affected files (+104, -0 lines): Documentation/notation/changing-defaults.ite