LGTM.
In light of the changes, let's have one more round of giving chances for
reviews.
http://codereview.appspot.com/4182056/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Hi,
Thanks for your watchfulness ! (Can we say this? I'm pretty bad at
English...)
I added Graham and Neil's changes.
Regards,
Bertrand
(Git patch attached with the commit's informations)
From fe20aad02a7c4a6ace4a9c31670b5f4c7dbe87ba Mon Sep 17 00:00:00 2001
From: Bertrand Bordage
Date: Thu, 24
Hi Betrand,
LGTM, apart from a few minor details.
Cheers,
Neil
http://codereview.appspot.com/4182056/diff/15002/ly/toc-init.ly
File ly/toc-init.ly (right):
http://codereview.appspot.com/4182056/diff/15002/ly/toc-init.ly#newcode32
ly/toc-init.ly:32: tocItemWithDotsMarkup = \markup \fill-with-p
Looks good!
Could you make one more version (changes below), then email me the
git format-patch origin
so I can push it?
http://codereview.appspot.com/4182056/diff/15002/Documentation/changes.tely
File Documentation/changes.tely (right):
http://codereview.appspot.com/4182056/diff/15002/Docum
New patch with Neil's changes.
http://codereview.appspot.com/4182056/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
http://codereview.appspot.com/4182056/diff/12001/Documentation/changes.tely
File Documentation/changes.tely (right):
http://codereview.appspot.com/4182056/diff/12001/Documentation/changes.tely#newcode65
Documentation/changes.tely:65: New markup commands @code{\pattern} and
@code{\fill-with-patte
lgtm
http://codereview.appspot.com/4182056/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
I added a "dir" argument to \pattern, so that we can get vertical
repeats.
Also made a changelog item.
Bertrand
http://codereview.appspot.com/4182056/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypon
Looks good. I had one comment.
Feel free to add an entry to the changelog. It's done by editing the
file Documentation/changes.tely
Thanks,
Carl
http://codereview.appspot.com/4182056/diff/7001/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):
http://codereview.ap
Maybe add \pattern to the changelog ?
http://codereview.appspot.com/4182056/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Changes done !
It is more clean now.
I'm not sure if the commands are in the right categories.
I also noticed numerous commands have @code instead of @var and vice
versa in their descriptions. Center-align's args or fill-line's
line-width for example.
Should I do a small patch to fix these ?
Reg
http://codereview.appspot.com/4182056/diff/1/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):
http://codereview.appspot.com/4182056/diff/1/scm/define-markup-commands.scm#newcode994
scm/define-markup-commands.scm:994: (define (nest-patterns pattern
pattern-width distanc
Reviewers: carl.d.sorensen_gmail.com,
Message:
A few questions.
http://codereview.appspot.com/4182056/diff/1/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):
http://codereview.appspot.com/4182056/diff/1/scm/define-markup-commands.scm#newcode994
scm/define-markup-comm
Looks very good.
Just a couple more comments.
Thanks,
Carl
http://codereview.appspot.com/4182056/diff/1/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):
http://codereview.appspot.com/4182056/diff/1/scm/define-markup-commands.scm#newcode994
scm/define-markup-comman
14 matches
Mail list logo
