Re: Add using Extract PDFmark for document building (issue 314130043 by truer...@gmail.com)

2016-11-19 Thread trueroad
Thank you for your advice. https://codereview.appspot.com/314130043/diff/20001/configure.ac File configure.ac (right): https://codereview.appspot.com/314130043/diff/20001/configure.ac#newcode305 configure.ac:305: [" documentation and the final PDF files.)"]) On 2016/11/19 14:06:07, pkx166h

Re: Add using Extract PDFmark for document building (issue 314130043 by truer...@gmail.com)

2016-11-19 Thread pkx166h
Domou Hosoda-Sama. https://codereview.appspot.com/314130043/diff/20001/configure.ac File configure.ac (right): https://codereview.appspot.com/314130043/diff/20001/configure.ac#newcode305 configure.ac:305: [" documentation and the final PDF files.)"]) All I would say is that "... and the final

Re: Add using Extract PDFmark for document building (issue 314130043 by truer...@gmail.com)

2016-11-19 Thread trueroad
On 2016/11/19 06:11:09, lemzwerg wrote: Ah, bad wording, sorry. I don't care about the actual length of the message but the line length in the source code, so please just wrap the message to stay within 80 columns or so if possible. Here's another version of the message which you might

Re: Add using Extract PDFmark for document building (issue 314130043 by truer...@gmail.com)

2016-11-18 Thread lemzwerg
Ah, bad wording, sorry. I don't care about the actual length of the message but the line length in the source code, so please just wrap the message to stay within 80 columns or so if possible. Here's another version of the message which you might consider. Optionally using gs >= 9.20

Re: Add using Extract PDFmark for document building (issue 314130043 by truer...@gmail.com)

2016-11-18 Thread trueroad
Reviewers: lemzwerg, Message: Thank you for your reviewing. https://codereview.appspot.com/314130043/diff/1/configure.ac File configure.ac (right): https://codereview.appspot.com/314130043/diff/1/configure.ac#newcode300 configure.ac:300: STEPMAKE_ADD_ENTRY(OPTIONAL,"(gs >= 9.20 and

Add using Extract PDFmark for document building (issue 314130043 by truer...@gmail.com)

2016-11-18 Thread lemzwerg
Very nice, LGTM! https://codereview.appspot.com/314130043/diff/1/configure.ac File configure.ac (right): https://codereview.appspot.com/314130043/diff/1/configure.ac#newcode300 configure.ac:300: STEPMAKE_ADD_ENTRY(OPTIONAL,"(gs >= 9.20 and extractpdfmark can reduce the disk space required for