Re: Additions in event-listener.ly (issue 152600043 by pkx1...@gmail.com)

2017-08-22 Thread pkx166h
author Thomas Morley Sat, 12 Aug 2017 10:34:42 +0100 (10:34 +0100) committer James Lowe Tue, 22 Aug 2017 10:04:17 +0100 (10:04 +0100) commit f0781fa82140814e371275e84802b3648970477a

Re: Additions in event-listener.ly (issue 152600043 by pkx1...@gmail.com)

2017-08-15 Thread pkx166h
https://codereview.appspot.com/152600043/diff/40001/ly/event-listener.ly File ly/event-listener.ly (right): https://codereview.appspot.com/152600043/diff/40001/ly/event-listener.ly#newcode220 ly/event-listener.ly:220: (note-event . format-note) ;; works for On 2017/08/14 20:36:07, marc wrote:

Re: Additions in event-listener.ly (issue 152600043 by pkx1...@gmail.com)

2017-08-14 Thread marc
Just a nitpick ... https://codereview.appspot.com/152600043/diff/40001/ly/event-listener.ly File ly/event-listener.ly (right): https://codereview.appspot.com/152600043/diff/40001/ly/event-listener.ly#newcode220 ly/event-listener.ly:220: (note-event . format-note) ;; works for The "works for"

Re: Additions in event-listener.ly (issue 152600043 by pkx1...@gmail.com)

2017-03-25 Thread thomasmorley65
On 2017/03/25 10:34:02, pkx166h wrote: Thanks to David (and Graham). I understand David's comments but don't have the knowledge (or the time) to make the edits that are suggested here - at least from as I understand it there would need to be some kind of 'check/test' (if/then)

Re: Additions in event-listener.ly (issue 152600043 by pkx1...@gmail.com)

2017-03-25 Thread pkx166h
Thanks to David (and Graham). I understand David's comments but don't have the knowledge (or the time) to make the edits that are suggested here - at least from as I understand it there would need to be some kind of 'check/test' (if/then) construction in format-note to decide if it was \Voice or

Re: Additions in event-listener.ly (issue 152600043 by pkx1...@gmail.com)

2017-03-22 Thread graham
On 2017/03/22 10:24:21, dak wrote: ly/event-listener.ly:69: (eq? 0 (ly:moment-grace-numerator moment)) Why this change for the worse? Numbers need to be compared with eqv? rather than eq? and I don't see that anything was wrong with zero? here since ly:moment-grace-numerator certainly cannot

Re: Additions in event-listener.ly (issue 152600043 by pkx1...@gmail.com)

2017-03-22 Thread dak
https://codereview.appspot.com/152600043/diff/1/ly/event-listener.ly File ly/event-listener.ly (right): https://codereview.appspot.com/152600043/diff/1/ly/event-listener.ly#newcode69 ly/event-listener.ly:69: (eq? 0 (ly:moment-grace-numerator moment)) Why this change for the worse? Numbers need

Re: Additions in event-listener.ly (issue 152600043 by pkx1...@gmail.com)

2017-03-22 Thread pkx166h
On 2014/10/17 06:40:24, Valentin Villenave wrote: Greetings Philippe and James, this looks good overall, I just have one minor comment. https://codereview.appspot.com/152600043/diff/1/ly/event-listener.ly File ly/event-listener.ly (right):

Additions in event-listener.ly (issue 152600043 by pkx1...@gmail.com)

2014-10-17 Thread v . villenave
Greetings Philippe and James, this looks good overall, I just have one minor comment. https://codereview.appspot.com/152600043/diff/1/ly/event-listener.ly File ly/event-listener.ly (right): https://codereview.appspot.com/152600043/diff/1/ly/event-listener.ly#newcode129