Re: Adds beam collision avoidance to auto beaming (issue4290069)

2011-03-30 Thread m...@apollinemike.com
On Mar 30, 2011, at 12:30 AM, hanw...@gmail.com wrote: > lgtm > > > http://codereview.appspot.com/4290069/diff/11001/lily/beam-collision-engraver.cc > File lily/beam-collision-engraver.cc (right): > > http://codereview.appspot.com/4290069/diff/11001/lily/beam-collision-engraver.cc#newcode64 > l

Re: Adds beam collision avoidance to auto beaming (issue4290069)

2011-03-29 Thread hanwenn
lgtm http://codereview.appspot.com/4290069/diff/11001/lily/beam-collision-engraver.cc File lily/beam-collision-engraver.cc (right): http://codereview.appspot.com/4290069/diff/11001/lily/beam-collision-engraver.cc#newcode64 lily/beam-collision-engraver.cc:64: for (vsize j = start; covered_grobs_

Re: Adds beam collision avoidance to auto beaming (issue4290069)

2011-03-29 Thread m...@apollinemike.com
On Mar 30, 2011, at 12:11 AM, Colin Campbell wrote: > On 11-03-29 08:24 PM, m...@apollinemike.com wrote: >> >> On Mar 29, 2011, at 10:12 PM, Colin Campbell wrote: >> >>> On 11-03-29 04:54 PM, m...@apollinemike.com wrote: On Mar 28, 2011, at 6:39 PM, percival.music...@gmail.com wrote:

Re: Adds beam collision avoidance to auto beaming (issue4290069)

2011-03-29 Thread Colin Campbell
On 11-03-29 08:24 PM, m...@apollinemike.com wrote: On Mar 29, 2011, at 10:12 PM, Colin Campbell wrote: On 11-03-29 04:54 PM, m...@apollinemike.com wrote: On Mar 28, 2011, at 6:39 PM, percival.music...@gmail.com wrote: Looks

Re: Adds beam collision avoidance to auto beaming (issue4290069)

2011-03-29 Thread m...@apollinemike.com
On Mar 29, 2011, at 10:12 PM, Colin Campbell wrote: > On 11-03-29 04:54 PM, m...@apollinemike.com wrote: >> On Mar 28, 2011, at 6:39 PM, percival.music...@gmail.com wrote: >> >>> Looks much more readable, thanks! >>> >>> >>> http://codereview.appspot.com/4290069/diff/11001/lily/beam-collision-e

Re: Adds beam collision avoidance to auto beaming (issue4290069)

2011-03-29 Thread m...@apollinemike.com
On Mar 29, 2011, at 10:12 PM, Colin Campbell wrote: > On 11-03-29 04:54 PM, m...@apollinemike.com wrote: >> On Mar 28, 2011, at 6:39 PM, percival.music...@gmail.com wrote: >> >>> Looks much more readable, thanks! >>> >>> >>> http://codereview.appspot.com/4290069/diff/11001/lily/beam-collision-e

Re: Adds beam collision avoidance to auto beaming (issue4290069)

2011-03-29 Thread Colin Campbell
On 11-03-29 04:54 PM, m...@apollinemike.com wrote: On Mar 28, 2011, at 6:39 PM, percival.music...@gmail.com wrote: Looks much more readable, thanks! http://codereview.appspot.com/4290069/diff/11001/lily/beam-collision-engraver.cc File lily/beam-collision-engraver.cc (right): http://coderevie

Re: Adds beam collision avoidance to auto beaming (issue4290069)

2011-03-29 Thread m...@apollinemike.com
On Mar 28, 2011, at 6:39 PM, percival.music...@gmail.com wrote: > Looks much more readable, thanks! > > > http://codereview.appspot.com/4290069/diff/11001/lily/beam-collision-engraver.cc > File lily/beam-collision-engraver.cc (right): > > http://codereview.appspot.com/4290069/diff/11001/lily/be

Re: Adds beam collision avoidance to auto beaming (issue4290069)

2011-03-28 Thread m...@apollinemike.com
On Mar 28, 2011, at 6:39 PM, percival.music...@gmail.com wrote: > Looks much more readable, thanks! > > > http://codereview.appspot.com/4290069/diff/11001/lily/beam-collision-engraver.cc > File lily/beam-collision-engraver.cc (right): > > http://codereview.appspot.com/4290069/diff/11001/lily/be

Re: Adds beam collision avoidance to auto beaming (issue4290069)

2011-03-28 Thread percival . music . ca
Looks much more readable, thanks! http://codereview.appspot.com/4290069/diff/11001/lily/beam-collision-engraver.cc File lily/beam-collision-engraver.cc (right): http://codereview.appspot.com/4290069/diff/11001/lily/beam-collision-engraver.cc#newcode59 lily/beam-collision-engraver.cc:59: // Star

Re: Adds beam collision avoidance to auto beaming (issue4290069)

2011-03-28 Thread mtsolo
New patch set uploaded. http://codereview.appspot.com/4290069/diff/8001/lily/beam-collision-engraver.cc File lily/beam-collision-engraver.cc (right): http://codereview.appspot.com/4290069/diff/8001/lily/beam-collision-engraver.cc#newcode50 lily/beam-collision-engraver.cc:50: sort (covered_grobs

Re: Adds beam collision avoidance to auto beaming (issue4290069)

2011-03-28 Thread n . puttock
http://codereview.appspot.com/4290069/diff/8001/lily/beam-collision-engraver.cc File lily/beam-collision-engraver.cc (right): http://codereview.appspot.com/4290069/diff/8001/lily/beam-collision-engraver.cc#newcode50 lily/beam-collision-engraver.cc:50: sort (covered_grobs_.begin (), covered_grobs

Re: Adds beam collision avoidance to auto beaming (issue4290069)

2011-03-28 Thread mtsolo
Fixed w/ Han-Wen's suggestions. http://codereview.appspot.com/4290069/diff/5001/lily/beam-collision-engraver.cc File lily/beam-collision-engraver.cc (right): http://codereview.appspot.com/4290069/diff/5001/lily/beam-collision-engraver.cc#newcode55 lily/beam-collision-engraver.cc:55: if (covered

Re: Adds beam collision avoidance to auto beaming (issue4290069)

2011-03-28 Thread Han-Wen Nienhuys
On Mon, Mar 28, 2011 at 8:13 AM, wrote: > > http://codereview.appspot.com/4290069/diff/5001/lily/beam-collision-engraver.cc > File lily/beam-collision-engraver.cc (right): > > http://codereview.appspot.com/4290069/diff/5001/lily/beam-collision-engraver.cc#newcode55 > lily/beam-collision-engraver.

Re: Adds beam collision avoidance to auto beaming (issue4290069)

2011-03-28 Thread hanwenn
http://codereview.appspot.com/4290069/diff/5001/lily/beam-collision-engraver.cc File lily/beam-collision-engraver.cc (right): http://codereview.appspot.com/4290069/diff/5001/lily/beam-collision-engraver.cc#newcode55 lily/beam-collision-engraver.cc:55: if (covered_grobs_.size ()) to drop 1 indent

Re: Adds beam collision avoidance to auto beaming (issue4290069)

2011-03-27 Thread m...@apollinemike.com
On Mar 27, 2011, at 3:29 PM, percival.music...@gmail.com wrote: > > http://codereview.appspot.com/4290069/diff/5001/lily/beam-collision-engraver.cc > File lily/beam-collision-engraver.cc (right): > > http://codereview.appspot.com/4290069/diff/5001/lily/beam-collision-engraver.cc#newcode55 > lily

Re: Adds beam collision avoidance to auto beaming (issue4290069)

2011-03-27 Thread percival . music . ca
http://codereview.appspot.com/4290069/diff/5001/lily/beam-collision-engraver.cc File lily/beam-collision-engraver.cc (right): http://codereview.appspot.com/4290069/diff/5001/lily/beam-collision-engraver.cc#newcode55 lily/beam-collision-engraver.cc:55: if (covered_grobs_.size ()) I'm going to sta

Adds beam collision avoidance to auto beaming (issue4290069)

2011-03-26 Thread mtsolo
Reviewers: , Message: Actualizes Han Wen's idea for putting everything in finalize. Seems to work... Cheers, Mike Description: Adds beam collision avoidance to auto beaming Please review this at http://codereview.appspot.com/4290069/ Affected files: M lily/beam-collision-engraver.cc ___