Re: Adds ly:define-event-class (issue1867050)

On 2010/10/02 16:02:37, Graham Percival wrote: As far as I can see, Mike has resolved all the known problems with this patch. Are there any other problems, or should we accept it? I'm working on it now. http://codereview.appspot.com/1867050/ ___ l

Re: Adds ly:define-event-class (issue1867050)

As far as I can see, Mike has resolved all the known problems with this patch. Are there any other problems, or should we accept it? http://codereview.appspot.com/1867050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mai

Re: Adds ly:define-event-class (issue1867050)

Reviewers: Neil Puttock, http://codereview.appspot.com/1867050/diff/17001/18001 File input/regression/scheme-text-spanner.ly (right): http://codereview.appspot.com/1867050/diff/17001/18001#newcode5 input/regression/scheme-text-spanner.ly:5: texidoc = "uses define-event-class to create a fully f

Re: Adds ly:define-event-class (issue1867050)

My comments in define-event-classes.scm don't work, so here goes: +(define-public (define-event-class leaf heritage) + (cond + ((not (eq? leaf (car heritage))) + (ly:warning "All classes must be the last in their matrilineal line.")) (ly:warning (_ "...") for translations + ((not (equal? (cdr he

Re: Adds ly:define-event-class (issue1867050)

http://codereview.appspot.com/1867050/diff/17001/18001 File input/regression/scheme-text-spanner.ly (right): http://codereview.appspot.com/1867050/diff/17001/18001#newcode201 input/regression/scheme-text-spanner.ly:201: a b c \schemeTextSpannerEnd d | + another spanner to check ly:engraver-annou

Adds ly:define-event-class (issue1867050)

Hi Mike, I don't trust Rietveld not to swallow my comments, so I'm posting a few at a time just in case it breaks again. :) Cheers, Neil http://codereview.appspot.com/1867050/diff/17001/18001 File input/regression/scheme-text-spanner.ly (right): http://codereview.appspot.com/1867050/diff/1700