Re: Advancing to Patch::review

2020-12-19 Thread Jonas Hahnfeld
Am Mittwoch, dem 02.12.2020 um 18:16 +0100 schrieb Jonas Hahnfeld: > > My gut feeling is that this should be somebody else than the MR author > > [...] To elaborate a bit, this tries to keep the pleasant effect that > somebody else at least opens your MR and nobody is tempted to change > labels

Advancing to Patch::review - RFC (was Re: Advancing to Patch::review)

2020-12-06 Thread James Lowe
On 02/12/2020 11:27, Michael Käppler wrote: On 01/12/2020 19:10, Jonas Hahnfeld wrote: FYI: 'make check' is running in pipelines for merge requests since this morning  So ... what does everyone think of this 'new' process? Apart from 'just now', I deliberately avoided checking/testing any

Re: Advancing to Patch::review

2020-12-03 Thread Jonas Hahnfeld
Am Donnerstag, dem 03.12.2020 um 12:33 + schrieb James: > On 03/12/2020 11:46, Michael Käppler wrote: > > What do you mean with "full reg test suite"? Additional examples that > > are not in the normal reg test suite? > > Well in the 'olden days' we'd have a set of tests on the website - here

Re: Advancing to Patch::review

2020-12-03 Thread James
On 03/12/2020 11:50, Michael Käppler wrote: "IIUC, a patch that fails 'make check' ('fails' in the sense of 'errors out') would have failed 'make test' in the old system, already." The 'old system' was me doing the tests manually in the order of make, make-testbaseline, make check, make

Re: Advancing to Patch::review

2020-12-03 Thread James
On 03/12/2020 11:50, Michael Käppler wrote: "IIUC, a patch that fails 'make check' ('fails' in the sense of 'errors out') would have failed 'make test' in the old system, already." The 'old system' was me doing the tests manually in the order of make, make-testbaseline, make check, make

Re: Advancing to Patch::review

2020-12-03 Thread James
On 03/12/2020 11:46, Michael Käppler wrote: What do you mean with "full reg test suite"? Additional examples that are not in the normal reg test suite? Well in the 'olden days' we'd have a set of tests on the website - here is an old URL that no longer works

Re: Advancing to Patch::review

2020-12-03 Thread Michael Käppler
Am 03.12.2020 um 12:46 schrieb Michael Käppler: [snip] No, that step remains manually, if I'm not mistaken. IIUC, a patch that fails 'make check' ('fails' in the sense of 'errors out') would have failed 'make test' already. As I understood the (old) process, setting a patch to 'Review' should

Re: Advancing to Patch::review

2020-12-03 Thread Michael Käppler
Am 03.12.2020 um 12:06 schrieb James: Hello, On 02/12/2020 20:57, Michael Käppler wrote: Am 02.12.2020 um 18:16 schrieb Jonas Hahnfeld: [snip] Circling back to my original proposal: My gut feeling is that this should be somebody else than the MR author Do I interpret your actions that you

Re: Advancing to Patch::review

2020-12-03 Thread James
Hello, On 02/12/2020 20:57, Michael Käppler wrote: Am 02.12.2020 um 18:16 schrieb Jonas Hahnfeld: [snip] Circling back to my original proposal: My gut feeling is that this should be somebody else than the MR author Do I interpret your actions that you disagree with this? To elaborate a bit,

Re: Advancing to Patch::review

2020-12-02 Thread Michael Käppler
Am 02.12.2020 um 18:16 schrieb Jonas Hahnfeld: [snip] Circling back to my original proposal: My gut feeling is that this should be somebody else than the MR author Do I interpret your actions that you disagree with this? To elaborate a bit, this tries to keep the pleasant effect that somebody

Re: Advancing to Patch::review

2020-12-02 Thread Jonas Hahnfeld
Am Mittwoch, dem 02.12.2020 um 12:37 +0100 schrieb Michael Käppler: > Am 02.12.2020 um 12:27 schrieb Michael Käppler: > > Am 02.12.2020 um 07:36 schrieb James Lowe: > > > On 01/12/2020 19:10, Jonas Hahnfeld wrote: > > > > FYI: 'make check' is running in pipelines for merge requests since this > >

Re: Advancing to Patch::review

2020-12-02 Thread Michael Käppler
Am 02.12.2020 um 12:27 schrieb Michael Käppler: Am 02.12.2020 um 07:36 schrieb James Lowe: On 01/12/2020 19:10, Jonas Hahnfeld wrote: FYI: 'make check' is running in pipelines for merge requests since this morning  One thing I forgot in that lengthy email two weeks ago was how MRs get to

Re: Advancing to Patch::review

2020-12-02 Thread Michael Käppler
Am 02.12.2020 um 07:36 schrieb James Lowe: On 01/12/2020 19:10, Jonas Hahnfeld wrote: FYI: 'make check' is running in pipelines for merge requests since this morning  One thing I forgot in that lengthy email two weeks ago was how MRs get to Patch::review. Traditionally James posted "Passes

Re: Advancing to Patch::review

2020-12-01 Thread James Lowe
On 01/12/2020 19:10, Jonas Hahnfeld wrote: FYI: 'make check' is running in pipelines for merge requests since this morning  One thing I forgot in that lengthy email two weeks ago was how MRs get to Patch::review. Traditionally James posted "Passes make check" and updated the labels

Advancing to Patch::review

2020-12-01 Thread Jonas Hahnfeld
FYI: 'make check' is running in pipelines for merge requests since this morning  One thing I forgot in that lengthy email two weeks ago was how MRs get to Patch::review. Traditionally James posted "Passes make check" and updated the labels accordingly. As 'make check' is now happening