LGTM
https://codereview.appspot.com/201140043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
https://codereview.appspot.com/201140043/diff/20001/lily/spanner.cc
File lily/spanner.cc (right):
https://codereview.appspot.com/201140043/diff/20001/lily/spanner.cc#newcode394
lily/spanner.cc:394: /*
On 2015/02/06 21:47:11, lemzwerg wrote:
Minor nit: Please use spaces, not tabs.
Done.
https
https://codereview.appspot.com/201140043/diff/20001/lily/spanner.cc
File lily/spanner.cc (right):
https://codereview.appspot.com/201140043/diff/20001/lily/spanner.cc#newcode394
lily/spanner.cc:394: /*
Minor nit: Please use spaces, not tabs.
https://codereview.appspot.com/201140043/
___
https://codereview.appspot.com/201140043/diff/20001/lily/spanner.cc
File lily/spanner.cc (right):
https://codereview.appspot.com/201140043/diff/20001/lily/spanner.cc#newcode404
lily/spanner.cc:404: Rod r;
Perhaps we should call this rod something else to underscore that it's
not the same rod as
https://codereview.appspot.com/201140043/diff/1/input/regression/minimum-length-after-break.ly
File input/regression/minimum-length-after-break.ly (right):
https://codereview.appspot.com/201140043/diff/1/input/regression/minimum-length-after-break.ly#newcode15
input/regression/minimum-length-aft
LGTM.
https://codereview.appspot.com/201140043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
https://codereview.appspot.com/201140043/diff/1/input/regression/minimum-length-after-break.ly
File input/regression/minimum-length-after-break.ly (right):
https://codereview.appspot.com/201140043/diff/1/input/regression/minimum-length-after-break.ly#newcode15
input/regression/minimum-length-aft
https://codereview.appspot.com/201140043/diff/1/input/regression/minimum-length-after-break.ly
File input/regression/minimum-length-after-break.ly (right):
https://codereview.appspot.com/201140043/diff/1/input/regression/minimum-length-after-break.ly#newcode15
input/regression/minimum-length-aft
Can't review the C++ part.
Some nitpicks in the regtest.
Will it be possible to tweak the first part of the Tie etc at line-end
as well?
With a combi of setting 'minimum-length-after-break' and
'minimum-length?
If yes, I'd show an example in the regtest. At least it should be
explained/demonstrat
Reviewers: ,
Message:
Please review.
Description:
Allow independent adjustment of minimum length for spanner siblings
The property minimum-length affects both unbroken and broken spanners,
making
independent adjustment impossible. This patch adds a property,
minimum-length-after-break, which,
10 matches
Mail list logo