Re: Allows lyrics to slide under TimeSignature when OctaveEight present. (issue 6201068)

2012-05-16 Thread mtsolo
On 2012/05/11 08:11:18, dak wrote: "m...@apollinemike.com" writes: > On 11 mai 2012, at 09:09, mailto:d...@gnu.org wrote: > >> >> http://codereview.appspot.com/6201068/diff/1/lily/pure-from-neighbor-engraver.cc >> File lily/pure-from-neighbor-engraver.cc (righ

Re: Allows lyrics to slide under TimeSignature when OctaveEight present. (issue 6201068)

2012-05-11 Thread David Kastrup
"m...@apollinemike.com" writes: > On 11 mai 2012, at 09:09, d...@gnu.org wrote: > >> >> http://codereview.appspot.com/6201068/diff/1/lily/pure-from-neighbor-engraver.cc >> File lily/pure-from-neighbor-engraver.cc (right): >> >> http://codereview.appspot.com/6201068/diff/1/lily/pure-from-neighbo

Re: Allows lyrics to slide under TimeSignature when OctaveEight present. (issue 6201068)

2012-05-11 Thread m...@apollinemike.com
On 11 mai 2012, at 09:09, d...@gnu.org wrote: > > http://codereview.appspot.com/6201068/diff/1/lily/pure-from-neighbor-engraver.cc > File lily/pure-from-neighbor-engraver.cc (right): > > http://codereview.appspot.com/6201068/diff/1/lily/pure-from-neighbor-engraver.cc#newcode56 > lily/pure-from-n

Re: Allows lyrics to slide under TimeSignature when OctaveEight present. (issue 6201068)

2012-05-11 Thread dak
http://codereview.appspot.com/6201068/diff/1/lily/pure-from-neighbor-engraver.cc File lily/pure-from-neighbor-engraver.cc (right): http://codereview.appspot.com/6201068/diff/1/lily/pure-from-neighbor-engraver.cc#newcode56 lily/pure-from-neighbor-engraver.cc:56: in_same_column (Grob *g1, Grob *g2

Re: Allows lyrics to slide under TimeSignature when OctaveEight present. (issue 6201068)

2012-05-10 Thread mtsolo
Reviewers: janek, carl.d.sorensen_gmail.com, http://codereview.appspot.com/6201068/diff/1/lily/pure-from-neighbor-engraver.cc File lily/pure-from-neighbor-engraver.cc (right): http://codereview.appspot.com/6201068/diff/1/lily/pure-from-neighbor-engraver.cc#newcode56 lily/pure-from-neighbor-engr

Re: Allows lyrics to slide under TimeSignature when OctaveEight present. (issue 6201068)

2012-05-10 Thread Carl . D . Sorensen
LGTM, but I concur with the line-wrap comment of Janek. http://codereview.appspot.com/6201068/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Allows lyrics to slide under TimeSignature when OctaveEight present. (issue 6201068)

2012-05-10 Thread janek . lilypond
http://codereview.appspot.com/6201068/diff/1/lily/pure-from-neighbor-engraver.cc File lily/pure-from-neighbor-engraver.cc (right): http://codereview.appspot.com/6201068/diff/1/lily/pure-from-neighbor-engraver.cc#newcode56 lily/pure-from-neighbor-engraver.cc:56: in_same_column (Grob *g1, Grob *g2