RE: Another patch

2020-05-10 Thread lilypond
org > Onderwerp: Re: Another patch > > On May 10, 2020, at 08:11, lilyp...@de-wolff.org wrote: > > > > I did replace all implicit casts to an int by a inline function, > > checking if the value is valid, and then casting to int. > > > > Together wi

Re: Another patch

2020-05-10 Thread Dan Eble
On May 10, 2020, at 08:11, lilyp...@de-wolff.org wrote: > > I did replace all implicit casts to an int by a inline function, checking if > the value is valid, and then casting to int. > > Together with my previous patch now all but one compiler warnings are > solved. Jaap, I love the fact

Another patch

2020-05-10 Thread lilypond
I did replace all implicit casts to an int by a inline function, checking if the value is valid, and then casting to int. Together with my previous patch now all but one compiler warnings are solved. Remark: I do not have git rights on the lilypond tree, so someone else should merge those

Re: Patchset for fixing 2604 and 2524, also contains another patch for CG (issue 6354044)

2012-06-29 Thread graham
LGTM, I think. I'm not completely certain what I'm reviewing here. I'm content to have this (whatever it is) go through, but in the future could you: - keep you changes in a separate git branch (locally) - run: git cl upload origin/master while on that local git branch. Yes, this will

Re: Patchset for fixing 2604 and 2524, also contains another patch for CG (issue 6354044)

2012-06-29 Thread John Mandereau
Il giorno ven, 29/06/2012 alle 11.00 +, gra...@percival-music.ca ha scritto: LGTM, I think. I'm not completely certain what I'm reviewing here. I'm content to have this (whatever it is) go through, but in the future could you: - keep you changes in a separate git branch (locally) -

Re: Patchset for fixing 2604 and 2524, also contains another patch for CG (issue 6354044)

2012-06-29 Thread David Kastrup
John Mandereau john.mander...@gmail.com writes: Il giorno ven, 29/06/2012 alle 11.00 +, gra...@percival-music.ca ha scritto: LGTM, I think. I'm not completely certain what I'm reviewing here. I'm content to have this (whatever it is) go through, but in the future could you: - keep

Patchset for fixing 2604 and 2524, also contains another patch for CG (issue 6354044)

2012-06-27 Thread graham
LGTM. One tweak, then it can be pushed directly to staging. http://codereview.appspot.com/6354044/diff/1/Documentation/contributor/administration.itexi File Documentation/contributor/administration.itexi (right):

Re: Patchset for fixing 2604 and 2524, also contains another patch for CG (issue 6354044)

2012-06-27 Thread john . mandereau
, also contains another patch for CG Oops, the two commits have been merged into one, but they were initially two. CG: improve Patchy documentation CG: Add LILYPOND_BUILD_DIR environment variable, fix issues 2604 and 2524. Please review this at http://codereview.appspot.com/6354044/ Affected

Re: Another patch (this one is important) to abc2ly

2006-10-05 Thread Laura Conrad
Juergen == Juergen Reuter [EMAIL PROTECTED] writes: except I find it harder to read. What do you think is the advantage of yours over mine? Juergen Your approach a = re.sub ( '-', '- ', a)# split words with - Juergen applies a rule which holds for most

Re: Another patch (this one is important) to abc2ly

2006-10-04 Thread Juergen Reuter
On Mon, 2 Oct 2006, Laura Conrad wrote: I just tested it and in actual code, yours seems to do the same thing mine does, N.B.: There should be a minor difference in the handling of white space before/after the hyphen, which however is not essential, I guess. except I find it harder to

Re: Another patch (this one is important) to abc2ly

2006-10-02 Thread Laura Conrad
Juergen == Juergen Reuter [EMAIL PROTECTED] writes: a = re.sub ( '-', '- ', a)# split words with - +a = re.sub ( ' - - ', ' -- ', a) # unless was originally -- Juergen Just being curious: Juergen Maybe I am totally wrong (since I do not know the abc format in

Re: Another patch (this one is important) to abc2ly

2006-10-01 Thread Juergen Reuter
a = re.sub ( '-', '- ', a)# split words with - +a = re.sub ( ' - - ', ' -- ', a) # unless was originally -- Just being curious: Maybe I am totally wrong (since I do not know the abc format in detail), but shouldn't this be rather something like a = re.sub (

Another patch (this one is important) to abc2ly

2006-09-30 Thread Laura Conrad
Translation of MIDI tempo is now the new sytax. Also the annoying erroneous error message about not being able to translate a numerator of 1 is fixed. ? scripts/out Index: ChangeLog === RCS file: