Ugh, found those unsent "Draft Comments" in my backlog, no idea whether
they still apply. Might be worth glancing over.
https://codereview.appspot.com/6498077/diff/28/lily/phrasing-slur-engraver.cc
File lily/phrasing-slur-engraver.cc (right):
https://codereview.appspot.com/6498077/diff/28/lily
http://codereview.appspot.com/6498077/diff/15001/lily/script-column.cc
File lily/script-column.cc (right):
http://codereview.appspot.com/6498077/diff/15001/lily/script-column.cc#newcode59
lily/script-column.cc:59: * avoid-staff of slur trumps script priority.
If one grob is
'avoid-slur supersede
http://codereview.appspot.com/6498077/diff/6033/lily/phrasing-slur-engraver.cc
File lily/phrasing-slur-engraver.cc (right):
http://codereview.appspot.com/6498077/diff/6033/lily/phrasing-slur-engraver.cc#newcode116
lily/phrasing-slur-engraver.cc:116: Grob *stub = make_spanner
("SlurStub", info.gr
On 10 sept. 2012, at 23:26, k-ohara5...@oco.net wrote:
> On 2012/09/07 16:23:21, mike7 wrote:
>> On 7 sept. 2012, at 09:34, mailto:k-ohara5...@oco.net wrote:
>
>>> Do you still think it possible to use just the real Slurs ?...
>>>
>>> 1) setting tentative control points using pre-line-breaking
On 2012/09/07 16:23:21, mike7 wrote:
On 7 sept. 2012, at 09:34, mailto:k-ohara5...@oco.net wrote:
> Do you still think it possible to use just the real Slurs ?...
>
> 1) setting tentative control points using pre-line-breaking
> estimates of heights (which are later replaced when the Slurs
> g
On 8 sept. 2012, at 18:43, m...@mikesolomon.org wrote:
>
> On 8 sept. 2012, at 09:06, Keith OHara wrote:
>
>> On Fri, 07 Sep 2012 09:23:08 -0700, m...@mikesolomon.org
>> wrote:
>>
>>>
>>> On 7 sept. 2012, at 09:34, k-ohara5...@oco.net wrote:
>>>
Having the invisible Grobs taking up s
On 8 sept. 2012, at 09:06, Keith OHara wrote:
> On Fri, 07 Sep 2012 09:23:08 -0700, m...@mikesolomon.org
> wrote:
>
>>
>> On 7 sept. 2012, at 09:34, k-ohara5...@oco.net wrote:
>>
>>> Having the invisible Grobs taking up space will confuse the innocent.
>>
>> I tried to add comments about t
On Fri, 07 Sep 2012 09:23:08 -0700, m...@mikesolomon.org
wrote:
On 7 sept. 2012, at 09:34, k-ohara5...@oco.net wrote:
Having the invisible Grobs taking up space will confuse the innocent.
I tried to add comments about this in the source - perhaps the CG needs an
invisible grob bit, as we
On 7 sept. 2012, at 09:34, k-ohara5...@oco.net wrote:
> On 2012/09/04 08:09:21, mike7 wrote:
>
>> On 4 sept. 2012, at 09:45, mailto:k-ohara5...@oco.net wrote:
>
>> > It makes no change for the Chopin; can you give an
>> > example where it helps?
>
>> In the Chopin, ragged-bottom is false so th
On 2012/09/04 08:09:21, mike7 wrote:
On 4 sept. 2012, at 09:45, mailto:k-ohara5...@oco.net wrote:
> It makes no change for the Chopin; can you give an
> example where it helps?
In the Chopin, ragged-bottom is false so the difference can't
really be seen. The piece isn't a good test case fo
On 5 sept. 2012, at 00:33, m...@mikesolomon.org wrote:
>
> On 4 sept. 2012, at 17:45, joenee...@gmail.com wrote:
>
>> On 2012/09/02 06:25:58, MikeSol wrote:
>>> On 2012/09/01 23:58:37, Keith wrote:
I might have a test case for you at
http://www.mutopiaproject.org/cgibin/piece-info.cgi?
On 4 sept. 2012, at 17:45, joenee...@gmail.com wrote:
> On 2012/09/02 06:25:58, MikeSol wrote:
>> On 2012/09/01 23:58:37, Keith wrote:
>>> I might have a test case for you at
>>> http://www.mutopiaproject.org/cgibin/piece-info.cgi?id=1776
>>>
>>> It seems you copy each slur into a "slur-stub", a
On 2012/09/02 06:25:58, MikeSol wrote:
On 2012/09/01 23:58:37, Keith wrote:
> I might have a test case for you at
> http://www.mutopiaproject.org/cgibin/piece-info.cgi?id=1776
>
> It seems you copy each slur into a "slur-stub", and from those keep
only the
> ones with "cross-staff" set. Then wh
On Tue, Sep 04, 2012 at 08:33:45AM +, d...@gnu.org wrote:
-snip review-
> So, _now_ please take every sentence and every answer in this mail,
> rewrite it in the form of a comment and stick it in the file in the
> places where people would be looking for it.
Yes.
> _This_ is the kind of infor
On 2012/09/04 08:09:21, mike7 wrote:
On 4 sept. 2012, at 09:45, mailto:k-ohara5...@oco.net wrote:
> Works for me. 16% slower than master.
> (I'll try make clean and make.)
> It makes no change for the Chopin; can you give an example where it
> helps?
In the Chopin, ragged-bottom is false s
On 4 sept. 2012, at 09:45, k-ohara5...@oco.net wrote:
> Works for me. 16% slower than master.
> (I'll try make clean and make.)
> It makes no change for the Chopin; can you give an example where it
> helps?
In the Chopin, ragged-bottom is false so the difference can't really be seen.
The piec
(I'll try make clean and make.)
16% slower than master.
It makes no change for the Chopin; can you give an example where it
helps?
http://codereview.appspot.com/6498077/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/m
Works for me. 16% slower than master.
(I'll try make clean and make.)
It makes no change for the Chopin; can you give an example where it
helps?
I still do not understand how creating separate SlurStubs helps. At the
time when we build system skylines, what information is in the stubs
that is n
The speed problem was twofold - some cruft in callbacks coupled with the
fact that I wasn't doing make cleans, so something about the way that
gcc was putting together the old .o files was slowing things down. I
learned my lesson: always do make clean before testing a patch.
A full make clean bri
On 2012/09/03 13:46:33, mike7 wrote:
On 3 sept. 2012, at 07:07, mailto:mts...@gmail.com wrote:
> On 2012/09/02 20:38:28, Keith wrote:
>> On 2012/09/02 06:25:58, MikeSol wrote:
>
>>> It's not a copy of the original slur because it is using
>>> pure heights and offsets.
>
>> I saw you interrogat
On 3 sept. 2012, at 07:07, mts...@gmail.com wrote:
> On 2012/09/02 20:38:28, Keith wrote:
>> On 2012/09/02 06:25:58, MikeSol wrote:
>
>>> It's not a copy of the original slur because it is using
>>> pure heights and offsets.
>
>> I saw you interrogating SlurStub regarding its purity, but did no
On 2012/09/02 20:38:28, Keith wrote:
On 2012/09/02 06:25:58, MikeSol wrote:
> It's not a copy of the original slur because it is using
> pure heights and offsets.
I saw you interrogating SlurStub regarding its purity, but did not
notice that
SlurStub took any different shape based on 'pur
On 2012/09/02 06:25:58, MikeSol wrote:
It's not a copy of the original slur because it is using
pure heights and offsets.
I saw you interrogating SlurStub regarding its purity, but did not
notice that SlurStub took any different shape based on 'pure' estimates.
The SlurStubs in the regtest we
http://codereview.appspot.com/6498077/diff/21/lily/phrasing-slur-engraver.cc
File lily/phrasing-slur-engraver.cc (right):
http://codereview.appspot.com/6498077/diff/21/lily/phrasing-slur-engraver.cc#newcode119
lily/phrasing-slur-engraver.cc:119: if (slur_stubs_.find (slurs_[j]) ==
slur_stubs_.en
Thanks for the review!
http://codereview.appspot.com/6498077/diff/21/lily/axis-group-interface.cc
File lily/axis-group-interface.cc (right):
http://codereview.appspot.com/6498077/diff/21/lily/axis-group-interface.cc#newcode419
lily/axis-group-interface.cc:419: */
On 2012/09/02 15:59:00, dak wro
http://codereview.appspot.com/6498077/diff/21/lily/axis-group-interface.cc
File lily/axis-group-interface.cc (right):
http://codereview.appspot.com/6498077/diff/21/lily/axis-group-interface.cc#newcode390
lily/axis-group-interface.cc:390: /*
Where is the point in putting a whole callback inside o
Reviewers: Keith,
Message:
On 2012/09/01 23:58:37, Keith wrote:
I might have a test case for you at
http://www.mutopiaproject.org/cgibin/piece-info.cgi?id=1776
It seems you copy each slur into a "slur-stub", and from those keep
only the
ones with "cross-staff" set. Then when figuring system
I might have a test case for you at
http://www.mutopiaproject.org/cgibin/piece-info.cgi?id=1776
It seems you copy each slur into a "slur-stub", and from those keep only
the ones with "cross-staff" set. Then when figuring system skylines you
insert all Grobs with the slur-stub-interface into the s
28 matches
Mail list logo
