Re: Avoid failed assertion in stem tremolo code (issue 572550043 by d...@gnu.org)

2019-04-08 Thread dak
Thanks for looking at this, Keith! I've tried to make a version that does the right thing with regard to the assertion failure. That does not address the root cause of the problem, nor does it fix the centering thing you pointed out. Quite lacklustre. https://codereview.appspot.com/572550043/

Re: Avoid failed assertion in stem tremolo code (issue 572550043 by d...@gnu.org)

2019-04-03 Thread k-ohara5a5a
https://codereview.appspot.com/572550043/diff/560590043/lily/stem-tremolo.cc File lily/stem-tremolo.cc (left): https://codereview.appspot.com/572550043/diff/560590043/lily/stem-tremolo.cc#oldcode175 lily/stem-tremolo.cc:175: Interval ph = stem->pure_y_extent (stem, 0, INT_MAX); My suggested cha

Avoid failed assertion in stem tremolo code (issue 572550043 by d...@gnu.org)

2019-04-03 Thread k-ohara5a5a
If I understand, the example \relative { a32 8..:32 } fails the assertion in the call to center() on line 182, because the interval 'ph' is empty. There are several problems in the existing code, that would seem to prevent it from working. The proposed change deviates further from what seems t