Re: Avoid macros in SATB framework. (issue 51230043)

2014-02-28 Thread tdanielsmusic
This patch seems to have stalled. @David: Could you perhaps spell out more clearly what needs to be done to meet your objections. Trevor https://codereview.appspot.com/51230043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gn

Re: Avoid macros in SATB framework. (issue 51230043)

2014-01-15 Thread tdanielsmusic
On 2014/01/14 14:30:45, dak wrote: https://codereview.appspot.com/51230043/diff/20001/ly/satb.ly#newcode75 ly/satb.ly:75: #(define-once Key *unspecified*) I don't see that using some Scheme interface rather than providing that facility on the LilyPond level makes a lot of sense. For one thin

Re: Avoid macros in SATB framework. (issue 51230043)

2014-01-14 Thread dak
https://codereview.appspot.com/51230043/diff/20001/ly/satb.ly File ly/satb.ly (right): https://codereview.appspot.com/51230043/diff/20001/ly/satb.ly#newcode75 ly/satb.ly:75: #(define-once Key *unspecified*) I don't see that using some Scheme interface rather than providing that facility on the L

Re: Avoid macros in SATB framework. (issue 51230043)

2014-01-13 Thread tdanielsmusic
LGTM I can deal with my comment before I push after the review if you like. Trevor https://codereview.appspot.com/51230043/diff/20001/ly/satb.ly File ly/satb.ly (right): https://codereview.appspot.com/51230043/diff/20001/ly/satb.ly#newcode260 ly/satb.ly:260: \version "2.18.0" This needs to be