On 2019/04/28 19:14:53, dak wrote:
Fix slur configuration too (thanks, Han-Wen)
I've downloaded you're patch. After playing around with it: all seems to
work nicely, no glitch found.
Thus, from testing:
LGTM
https://codereview.appspot.com/576610043/
hanw...@gmail.com writes:
> On 2019/04/26 18:49:03, dak wrote:
>> mailto:hanw...@gmail.com writes:
>
>> > add a regression test?
>> >
>> > https://codereview.appspot.com/576610043/
>
>> I am not sure what the point of it would be. This kind of bug may be
>> present elsewhere (and the regression
On 2019/04/26 18:49:03, dak wrote:
mailto:hanw...@gmail.com writes:
> add a regression test?
>
> https://codereview.appspot.com/576610043/
I am not sure what the point of it would be. This kind of bug may be
present elsewhere (and the regression test would not cover that) and
it
is not
hanw...@gmail.com writes:
> add a regression test?
>
> https://codereview.appspot.com/576610043/
I am not sure what the point of it would be. This kind of bug may be
present elsewhere (and the regression test would not cover that) and it
is not likely to get reintroduced here since this code
add a regression test?
https://codereview.appspot.com/576610043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM
https://codereview.appspot.com/576610043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
thomasmorle...@gmail.com writes:
> As always, I can't review C++.
>
> So let me ask, how will LilyPond react seeing 5 or more control-points
> after your patch?
>
> https://codereview.appspot.com/576610043/
It just ignores additional control points and replaces missing ones with
(0 . 0).
--
As always, I can't review C++.
So let me ask, how will LilyPond react seeing 5 or more control-points
after your patch?
https://codereview.appspot.com/576610043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
