Re: Better pure heights for slurs (issue 5431065)

Passes Make. Reg tests here http://lilypond-stuff.1065243.n5.nabble.com/Tracker-2051-28-November-Test-results-td5029591.html James http://codereview.appspot.com/5431065/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/ma

Re: Better pure heights for slurs (issue 5431065)

On Nov 27, 2011, at 11:16 PM, k-ohara5...@oco.net wrote: > LGTM > Removing the contribution from 'height-limit' to estimated slur heights > is very helpful. It was never appropriate to add 'height-limit' to the > extent of the slurred notes, because the note or stem furthest in the > direction of

Re: Better pure heights for slurs (issue 5431065)

LGTM Removing the contribution from 'height-limit' to estimated slur heights is very helpful. It was never appropriate to add 'height-limit' to the extent of the slurred notes, because the note or stem furthest in the direction of the slur is much closer to the curve of the slur than 'height-limi

Re: Better pure heights for slurs (issue 5431065)

On Nov 26, 2011, at 4:11 AM, k-ohara5...@oco.net wrote: > On 2011/11/26 02:09:57, Keith wrote: >> Maybe the *0.5 was converting half-staff-spaces to staff-spaces > No; the units are fine. > > The problem seems to be not so much the overestimate of the slur extent, > but that said overestimate of

Re: OT: Vocal music (was Re: Better pure heights for slurs (issue 5431065))

I saw Steven Schick and Shahrokh Yadegari perform this live, and it literally changed me as a musician — one of the top ten artistic experiences of my entire life. Here's a sample: Of course, video doesn't match the insane spectacularity of the live performance (both by Schick and the live pro

Re: Better pure heights for slurs (issue 5431065)

Keith, retested. http://code.google.com/p/lilypond/issues/detail?id=2051#c9 passes make and a new set of reg test diffs are up. James http://codereview.appspot.com/5431065/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.or

Re: Better pure heights for slurs (issue 5431065)

On 2011/11/26 02:09:57, Keith wrote: Maybe the *0.5 was converting half-staff-spaces to staff-spaces No; the units are fine. The problem seems to be not so much the overestimate of the slur extent, but that said overestimate of space is allowed before each each script with avoid-slur 'outside :

Re: Better pure heights for slurs (issue 5431065)

On 2011/11/26 01:42:33, Keith wrote: On 2011/11/25 05:01:39, http://mike_apollinemike.com wrote: > > Does it actually work? It used to. I take that back. The override you emailed a while back setting pure-height = 0 worked great, but none of these patches help much. The patch based on my

Re: Better pure heights for slurs (issue 5431065)

On 2011/11/26 01:42:33, Keith wrote: On 2011/11/25 05:01:39, http://mike_apollinemike.com wrote: > > Does it actually work? It used to. I take that back. The override you emailed a while back setting pure-height = 0 worked great, but none of these patches help much. The patch based on my

Re: Better pure heights for slurs (issue 5431065)

On 2011/11/25 05:01:39, mike_apollinemike.com wrote: On Thu, 24 Nov 2011 19:16:46 +, mailto:k-ohara5...@oco.net wrote: > I like the direction of this change. Does it actually work? It used to. You should try your patches, occasionally. Take Carl's example from

Re: Better pure heights for slurs (issue 5431065)

Passes Make and reg tests are here http://code.google.com/p/lilypond/issues/detail?id=2051#c6 james http://codereview.appspot.com/5431065/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Better pure heights for slurs (issue 5431065)

passes make - reg test diffs attached here: http://code.google.com/p/lilypond/issues/detail?id=2051#c4 James http://codereview.appspot.com/5431065/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond

Re: Better pure heights for slurs (issue 5431065)

>> The code has your trademark incomprehensibility, > > Thank you, Keith. You know, sometimes, people think that it comes > naturally to be so incomprehensible, but it's actually hard work. > Usually, before writing LilyPond code, I'll read a passage from > either Finnegans Wake or Waiting for Go

Re: Better pure heights for slurs (issue 5431065)

I've uploaded a new patch set where I've eliminated the 0.5 * height_limit. This will likely make slur pure heights worse (meaning they'll overshoot more), but I cannot find a good rationale for why the 0.5 was there in the first place so I took it out. http://codereview.appspot.com/5431065/ __

Re: Better pure heights for slurs (issue 5431065)

On Thu, 24 Nov 2011 19:16:46 +, k-ohara5...@oco.net wrote: I like the direction of this change. Does it actually work? The code has your trademark incomprehensibility, Thank you, Keith. You know, sometimes, people think that it comes naturally to be so incomprehensible, but it's actua

Re: Better pure heights for slurs (issue 5431065)

k-ohara5...@oco.net writes: > I like the direction of this change. > > The code has your trademark incomprehensibility, so I don't know if it > does what you want based on your introduction. Maybe just decide that > you want what it does. Makes me wonder what the trademark of "nobody ever commen

Re: Better pure heights for slurs (issue 5431065)

I like the direction of this change. The code has your trademark incomprehensibility, so I don't know if it does what you want based on your introduction. Maybe just decide that you want what it does. http://codereview.appspot.com/5431065/diff/1/lily/slur.cc File lily/slur.cc (right): http://

Re: Better pure heights for slurs (issue 5431065)

Passes make and reg test diff here http://lilypond-stuff.1065243.n5.nabble.com/Tracker-issue-2051-24-November-td4986583.html James http://codereview.appspot.com/5431065/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mai

Better pure heights for slurs (issue 5431065)

Reviewers: , Message: Hey all, I'm not sure if this patch will make a big difference, but it should help the pure height problem a little bit. Before, pure heights were calculated using the entire height of the slur. For slurs with a slope, this is an overshoot. I thus use an estimate of the