Seems reasonable to me.
I couldn't think of any way to generalize the internal call.
Carl
http://codereview.appspot.com/4517051/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On May 11, 2011, at 9:51 AM, carl.d.soren...@gmail.com wrote:
Seems reasonable to me.
I couldn't think of any way to generalize the internal call.
Carl
http://codereview.appspot.com/4517051/
Thanks!
There is a note in arpeggio.cc saying that width cannot be gleaned from the
print
On 11 May 2011 15:18, m...@apollinemike.com m...@apollinemike.com wrote:
There is a note in arpeggio.cc saying that width cannot be gleaned from the
print function because it triggers a vertical alignment when arpeggios are
cross-staff. By turning the function into an internal function and
http://codereview.appspot.com/4517051/diff/1/lily/arpeggio.cc
File lily/arpeggio.cc (right):
http://codereview.appspot.com/4517051/diff/1/lily/arpeggio.cc#newcode98
lily/arpeggio.cc:98: MAKE_SCHEME_CALLBACK (Arpeggio, internal_print, 1);
Why are you exporting these internal functions?
On May 11, 2011, at 12:02 PM, n.putt...@gmail.com wrote:
http://codereview.appspot.com/4517051/diff/1/lily/arpeggio.cc
File lily/arpeggio.cc (right):
http://codereview.appspot.com/4517051/diff/1/lily/arpeggio.cc#newcode98
lily/arpeggio.cc:98: MAKE_SCHEME_CALLBACK (Arpeggio,
On May 11, 2011, at 2:19 PM, Neil Puttock wrote:
On 11 May 2011 19:11, m...@apollinemike.com wrote:
The issue is that, for the chord bracket and chord slur (and Bertrand's
eventual chord brace, which hypothetically varies significantly in its X
dimension as it gets larger), the width of
Reviewers: ,
Message:
I had added a Rietveld issue about this, but the example on my Rietveld
issue was bunk so I pulled it. The current width function in
arpeggio.cc does not give the correct width for chord brackets or chord
slurs, nor does it give the correct width for arpeggios with arrows
