Re: Change all occurences of echo -n to printf for portability (issue 5903046)

2012-03-26 Thread graham
LGTM, I think this could be pushed immediately? http://codereview.appspot.com/5903046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Change all occurences of echo -n to printf for portability (issue 5903046)

2012-03-26 Thread dak
On 2012/03/26 06:02:09, Graham Percival wrote: LGTM, I think this could be pushed immediately? I would be surprised if there was any part in it that could still benefit from further review/countdown. http://codereview.appspot.com/5903046/ ___

Change all occurences of echo -n to printf for portability (issue 5903046)

2012-03-24 Thread dak
http://codereview.appspot.com/5903046/diff/1/scripts/build/install-info-html.sh File scripts/build/install-info-html.sh (right): http://codereview.appspot.com/5903046/diff/1/scripts/build/install-info-html.sh#newcode129 scripts/build/install-info-html.sh:129: printf $name: Writing index:

Re: Change all occurences of echo -n to printf for portability (issue 5903046)

2012-03-24 Thread dak
http://codereview.appspot.com/5903046/diff/1/smart-autogen.sh File smart-autogen.sh (right): http://codereview.appspot.com/5903046/diff/1/smart-autogen.sh#newcode16 smart-autogen.sh:16: printf $AUTOGEN_INPUT_CHECKSUM $CHECKSUM_FILE On 2012/03/24 06:00:52, dak wrote: I'd prefer %s

Re: Change all occurences of echo -n to printf for portability (issue 5903046)

2012-03-24 Thread dak
http://codereview.appspot.com/5903046/diff/6001/smart-autogen.sh File smart-autogen.sh (right): http://codereview.appspot.com/5903046/diff/6001/smart-autogen.sh#newcode16 smart-autogen.sh:16: printf %s $AUTOGEN_INPUT_CHECKSUM $CHECKSUM_FILE Remove trailing space in this line before pushing.