I have nothing to say other than seconding comments from Graham.
http://codereview.appspot.com/6442068/diff/1/make/lysdoc-vars.make
File make/lysdoc-vars.make (left):
http://codereview.appspot.com/6442068/diff/1/make/lysdoc-vars.make#oldcode10
make/lysdoc-vars.make:10: LILYPOND_BOOK_FLAGS +=
- Original Message -
From: john.mander...@gmail.com
To: philehol...@googlemail.com; gra...@percival-music.ca
Cc: lilypond-devel@gnu.org; re...@codereview-hr.appspotmail.com
Sent: Wednesday, August 01, 2012 5:32 PM
Subject: Re: Changes make test to allow output to be reviewed in a browser
Reviewers: Graham Percival,
Message:
Please review.
Description:
As the title says, really. To date, running make test creates only .ps
files which it's difficult to check. This changes the output to .png,
which means that collated-files.html can be opened by a browser and the
reg tests
I'm extremely cautious about _removing_ the ps output, since that might
break the regtest comparisons in GUB. Have you / could you test this?
I'd be much happier if this patch created pngs *in addition* to ps. I
don't think we need to worry about making the process 10% or even 20%
slower.
