Re: Changes make test to allow output to be reviewed in a browser (issue 6442068)

2012-08-01 Thread Phil Holmes
- Original Message - From: To: ; Cc: ; Sent: Wednesday, August 01, 2012 5:32 PM Subject: Re: Changes make test to allow output to be reviewed in a browser (issue 6442068) I have nothing to say other than seconding comments from Graham. http://codereview.appspot.com/6442068/diff

Re: Changes make test to allow output to be reviewed in a browser (issue 6442068)

2012-08-01 Thread john . mandereau
I have nothing to say other than seconding comments from Graham. http://codereview.appspot.com/6442068/diff/1/make/lysdoc-vars.make File make/lysdoc-vars.make (left): http://codereview.appspot.com/6442068/diff/1/make/lysdoc-vars.make#oldcode10 make/lysdoc-vars.make:10: LILYPOND_BOOK_FLAGS += --

Re: Changes make test to allow output to be reviewed in a browser (issue 6442068)

2012-07-31 Thread graham
I'm extremely cautious about _removing_ the ps output, since that might break the regtest comparisons in GUB. Have you / could you test this? I'd be much happier if this patch created pngs *in addition* to ps. I don't think we need to worry about making the process 10% or even 20% slower. htt

Changes make test to allow output to be reviewed in a browser (issue 6442068)

2012-07-31 Thread PhilEHolmes
Reviewers: Graham Percival, Message: Please review. Description: As the title says, really. To date, running make test creates only .ps files which it's difficult to check. This changes the output to .png, which means that collated-files.html can be opened by a browser and the reg tests checke