Re: Checks for recursive element behavior (issue 6943072)

2012-12-22 Thread Keith OHara
On Sat, 22 Dec 2012 00:46:21 -0800, wrote: In this particular case, however, the problem is adding an axis group to an axis group. _Any_ old axis group to _any_ old axis group. No no. The reported problem \new StaffGroup \RemoveEmptyStaves <> causes a StaffGrouper to be added to the Vert

Re: Checks for recursive element behavior (issue 6943072)

2012-12-22 Thread m...@mikesolomon.org
On 22 déc. 2012, at 09:46, d...@gnu.org wrote: > On 2012/12/22 08:29:59, mike7 wrote: >> Where in the new code are things being allocated and thrown away > temporarily on >> the heap? > > What do you think extract_grob_set does? Got it. > >> If there is a more efficient way to implement this p

Re: Checks for recursive element behavior (issue 6943072)

2012-12-22 Thread dak
On 2012/12/22 08:29:59, mike7 wrote: Where in the new code are things being allocated and thrown away temporarily on the heap? What do you think extract_grob_set does? If there is a more efficient way to implement this patch, let me know. It seems, though, that the only way to prevent gr

Re: Checks for recursive element behavior (issue 6943072)

2012-12-22 Thread m...@mikesolomon.org
On 22 déc. 2012, at 09:25, d...@gnu.org wrote: > On 2012/12/22 06:41:06, mike7 wrote: >> On 21 déc. 2012, at 10:09, mailto:d...@gnu.org wrote: > >> > On 2012/12/21 07:59:02, MikeSol wrote: >> >> Hey all, >> > >> >> I'm ok w/ this on the countdown but can someone check out David's >> > suspicion

Re: Checks for recursive element behavior (issue 6943072)

2012-12-22 Thread dak
On 2012/12/22 06:41:06, mike7 wrote: On 21 déc. 2012, at 10:09, mailto:d...@gnu.org wrote: > On 2012/12/21 07:59:02, MikeSol wrote: >> Hey all, > >> I'm ok w/ this on the countdown but can someone check out David's > suspicion that >> this slows stuff down by O(n^3)? I definitely won't push t

Re: Checks for recursive element behavior (issue 6943072)

2012-12-21 Thread k-ohara5a5a
http://en.wiktionary.org/wiki/irony https://codereview.appspot.com/6943072/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Checks for recursive element behavior (issue 6943072)

2012-12-21 Thread m...@mikesolomon.org
On 21 déc. 2012, at 10:09, d...@gnu.org wrote: > On 2012/12/21 07:59:02, MikeSol wrote: >> Hey all, > >> I'm ok w/ this on the countdown but can someone check out David's > suspicion that >> this slows stuff down by O(n^3)? I definitely won't push this if it > slows >> LilyPond down to a crawl.

Re: Checks for recursive element behavior (issue 6943072)

2012-12-21 Thread k-ohara5a5a
On 2012/12/21 07:59:02, MikeSol wrote: I'm ok w/ this on the countdown but can someone check out David's suspicion that this slows stuff down by O(n^3)? I definitely won't push this if it slows LilyPond down to a crawl. Don't worry; I'm sure we'll hear about it in lilypond-user if there is a p

Re: Checks for recursive element behavior (issue 6943072)

2012-12-21 Thread dak
On 2012/12/21 07:59:02, MikeSol wrote: Hey all, I'm ok w/ this on the countdown but can someone check out David's suspicion that this slows stuff down by O(n^3)? I definitely won't push this if it slows LilyPond down to a crawl. I am not ok with that. It looks really, really, really ex

Checks for recursive element behavior (issue 6943072)

2012-12-20 Thread mtsolo
Reviewers: , Message: Hey all, I'm ok w/ this on the countdown but can someone check out David's suspicion that this slows stuff down by O(n^3)? I definitely won't push this if it slows LilyPond down to a crawl. Cheers, MS Description: Checks for recursive element behavior Please review this