https://codereview.appspot.com/321930043/diff/160001/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):
https://codereview.appspot.com/321930043/diff/160001/Documentation/notation/simultaneous.itely#newcode917
One nit. See below.
No need for a new patch-set, imho. You could change it right before
pushing.
Otherwise LGTM
https://codereview.appspot.com/321930043/diff/160001/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):
I think this one warrants an entry in changes.
https://codereview.appspot.com/321930043/diff/140001/scm/scheme-engravers.scm
File scm/scheme-engravers.scm (right):
https://codereview.appspot.com/321930043/diff/140001/scm/scheme-engravers.scm#newcode152
scm/scheme-engravers.scm:152: (define
On 2017/05/27 20:03:43, horndude77 wrote:
> On 2017/05/21 17:12:26, thomasmorley651 wrote:
> > I'd like to mention another point:
> > What to do with pitched rests and rests with user-set
staff-position, merge
> them
> > automatically to the zero-position?
>
> If a user has explicitly set the
On 2017/05/21 17:12:26, thomasmorley651 wrote:
> I'd like to mention another point:
> What to do with pitched rests and rests with user-set
staff-position, merge
them
> automatically to the zero-position?
If a user has explicitly set the position of a rest this should be
honoured
by
https://codereview.appspot.com/321930043/diff/11/scm/scheme-engravers.scm
File scm/scheme-engravers.scm (right):
https://codereview.appspot.com/321930043/diff/11/scm/scheme-engravers.scm#newcode167
scm/scheme-engravers.scm:167: (lambda (rest) (ly:grob-set-property! rest
'Y-offset
On 2017/05/21 17:12:26, thomasmorley651 wrote:
I'd like to mention another point:
What to do with pitched rests and rests with user-set staff-position,
merge them
automatically to the zero-position?
If a user has explicitly set the position of a rest this should be
honoured
by default, I
I'd like to mention another point:
What to do with pitched rests and rests with user-set staff-position,
merge them automatically to the zero-position?
I'd say using suspendRestMerging-property is sufficient to cover this
case, but this is only me. Other opinions?
On 2017/05/21 04:27:33, horndude77 wrote:
https://codereview.appspot.com/321930043/diff/11/scm/scheme-engravers.scm
File scm/scheme-engravers.scm (right):
https://codereview.appspot.com/321930043/diff/11/scm/scheme-engravers.scm#newcode151
scm/scheme-engravers.scm:151: (define
https://codereview.appspot.com/321930043/diff/11/scm/scheme-engravers.scm
File scm/scheme-engravers.scm (right):
https://codereview.appspot.com/321930043/diff/11/scm/scheme-engravers.scm#newcode151
scm/scheme-engravers.scm:151: (define (rest-eqv rest-len-prop)
On 2017/05/20 12:18:33,
Looks much better -- see comments below.
https://codereview.appspot.com/321930043/diff/11/scm/scheme-engravers.scm
File scm/scheme-engravers.scm (right):
https://codereview.appspot.com/321930043/diff/11/scm/scheme-engravers.scm#newcode167
scm/scheme-engravers.scm:167: (lambda (rest)
Much better now, though:
https://codereview.appspot.com/321930043/diff/11/scm/scheme-engravers.scm
File scm/scheme-engravers.scm (right):
https://codereview.appspot.com/321930043/diff/11/scm/scheme-engravers.scm#newcode151
scm/scheme-engravers.scm:151: (define (rest-eqv rest-len-prop)
https://codereview.appspot.com/321930043/diff/60001/ly/init.ly
File ly/init.ly (right):
https://codereview.appspot.com/321930043/diff/60001/ly/init.ly#newcode36
ly/init.ly:36: #(use-modules (scm merge-rests-engraver))
On 2017/05/18 14:15:23, david.nalesnik wrote:
I'm not sure why you are
https://codereview.appspot.com/321930043/diff/60001/scm/merge-rests-engraver.scm
File scm/merge-rests-engraver.scm (right):
https://codereview.appspot.com/321930043/diff/60001/scm/merge-rests-engraver.scm#newcode10
scm/merge-rests-engraver.scm:10: (define (rest-length rest)
This definition is
https://codereview.appspot.com/321930043/diff/60001/ly/init.ly
File ly/init.ly (right):
https://codereview.appspot.com/321930043/diff/60001/ly/init.ly#newcode36
ly/init.ly:36: #(use-modules (scm merge-rests-engraver))
I'm not sure why you are defining a separate module. The usual
procedure
Passes make, make check and a full make doc.
https://codereview.appspot.com/321930043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
16 matches
Mail list logo
