Re: Creates a LeftBarStub that stops lyrics from bumping into the SystemStartBar. (issue 5201043)

2011-10-10 Thread mtsolo
I got a little ahead of myself...the patch, while it works in the regtest cases, does not work the way I think it did because all Items' pure heights are calculated from 0 to INT_MAX in Separation_item::boxes. Certain NonMusicalPaperColumns' horizontal skylines will change depending on if they be

Re: Creates a LeftBarStub that stops lyrics from bumping into the SystemStartBar. (issue 5201043)

2011-10-10 Thread mtsolo
This new patch set eliminates all regtest diffs via a mechanism that allows extremal lyrics to be flush with the left edge. It kinda sorta bends LilyPond into doing something it is not designed to do :: returning pureY-extents for items that are dependent on the start and end positions (normally,

Re: Creates a LeftBarStub that stops lyrics from bumping into the SystemStartBar. (issue 5201043)

2011-10-08 Thread n . puttock
http://codereview.appspot.com/5201043/diff/3001/scm/output-lib.scm File scm/output-lib.scm (right): http://codereview.appspot.com/5201043/diff/3001/scm/output-lib.scm#newcode355 scm/output-lib.scm:355: (if (eq? 0 (ly:item-break-dir grob)) Doesn't this potentially make the function unpure? If I

Re: Creates a LeftBarStub that stops lyrics from bumping into the SystemStartBar. (issue 5201043)

2011-10-07 Thread pkx166h
Passes make and make check shows 2 reg test diffs that Mike seems to think are expected attached at: http://code.google.com/p/lilypond/issues/detail?id=1956#c3 http://codereview.appspot.com/5201043/ ___ lilypond-devel mailing list lilypond-devel@gnu.

Re: Creates a LeftBarStub that stops lyrics from bumping into the SystemStartBar. (issue 5201043)

2011-10-07 Thread mtsolo
Reviewers: J_lowe, Message: On 2011/10/06 19:41:26, J_lowe wrote: passes make but I get a programming error show up on make check (as well as half a dozen reg test diffs). See attached http://code.google.com/p/lilypond/issues/detail?id=1956#c1 All these are fixed. Now, the only diffs

Creates a LeftBarStub that stops lyrics from bumping into the SystemStartBar. (issue 5201043)

2011-10-06 Thread pkx166h
passes make but I get a programming error show up on make check (as well as half a dozen reg test diffs). See attached http://code.google.com/p/lilypond/issues/detail?id=1956#c1 http://codereview.appspot.com/5201043/ ___ lilypond-devel mailing list l