Re: CueClefs: Use middleCClefPosition in the key engraver (issue4551101)

2011-06-21 Thread percival . music . ca
LGTM, please push after making the small changes requested by Neil. http://codereview.appspot.com/4551101/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: CueClefs: Use middleCClefPosition in the key engraver (issue4551101)

2011-06-13 Thread Jan WarchoĊ‚
LGTM. Btw, is it possible to download a source file from Rietveld? I'd like to copy the regression test written by Reinhold, and i'm too lazy to remove all the '+' at the beggining of lines manually... Janek ___ lilypond-devel mailing list lilypond-dev

Re: CueClefs: Use middleCClefPosition in the key engraver (issue4551101)

2011-06-12 Thread n . puttock
LGTM. http://codereview.appspot.com/4551101/diff/1/input/regression/cue-clef-keysignature.ly File input/regression/cue-clef-keysignature.ly (right): http://codereview.appspot.com/4551101/diff/1/input/regression/cue-clef-keysignature.ly#newcode1 input/regression/cue-clef-keysignature.ly:1: \vers

Re: CueClefs: Use middleCClefPosition in the key engraver (issue4551101)

2011-06-07 Thread Carl . D . Sorensen
LGTM. Carl http://codereview.appspot.com/4551101/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

CueClefs: Use middleCClefPosition in the key engraver (issue4551101)

2011-06-07 Thread percival . music . ca
thanks, added as http://code.google.com/p/lilypond/issues/detail?id=1684 http://codereview.appspot.com/4551101/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel