Re: Doc: Added note to CG about disable-optimizing (issue 5081048)

2011-09-25 Thread pkx166h
Pushed as commit0290695173284ccf68b08c0e92734d76df7120fd Graham ok'd this. James http://codereview.appspot.com/5081048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Added note to CG about disable-optimizing (issue 5081048)

2011-09-25 Thread percival . music . ca
LGTM, go ahead and push http://codereview.appspot.com/5081048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Added note to CG about disable-optimizing (issue 5081048)

2011-09-21 Thread percival . music . ca
http://codereview.appspot.com/5081048/diff/1/Documentation/contributor/regressions.itexi File Documentation/contributor/regressions.itexi (right): http://codereview.appspot.com/5081048/diff/1/Documentation/contributor/regressions.itexi#newcode143 Documentation/contributor/regressions.itexi:143:

Re: Doc: Added note to CG about disable-optimizing (issue 5081048)

2011-09-21 Thread ColinPKCampbell
http://codereview.appspot.com/5081048/diff/1/Documentation/contributor/regressions.itexi File Documentation/contributor/regressions.itexi (right): http://codereview.appspot.com/5081048/diff/1/Documentation/contributor/regressions.itexi#newcode143 Documentation/contributor/regressions.itexi:143:

Re: Doc: Added note to CG about disable-optimizing (issue 5081048)

2011-09-21 Thread Peekay Ex
On Wed, Sep 21, 2011 at 10:01 AM, wrote: > On 2011/09/21 08:43:09, Trevor Daniels wrote: >> >> But if you leave the configure option in it should be >> ./configure. > > Ah, that was a bit simplistic.  In-tree and out-of-tree > builds are different wrt configure, I think. > > http://codereview.app

Re: Doc: Added note to CG about disable-optimizing (issue 5081048)

2011-09-21 Thread tdanielsmusic
On 2011/09/21 08:43:09, Trevor Daniels wrote: But if you leave the configure option in it should be ./configure. Ah, that was a bit simplistic. In-tree and out-of-tree builds are different wrt configure, I think. http://codereview.appspot.com/5081048/

Doc: Added note to CG about disable-optimizing (issue 5081048)

2011-09-21 Thread tdanielsmusic
LGTM, with one comment http://codereview.appspot.com/5081048/diff/1/Documentation/contributor/regressions.itexi File Documentation/contributor/regressions.itexi (right): http://codereview.appspot.com/5081048/diff/1/Documentation/contributor/regressions.itexi#newcode143 Documentation/contributor