Re: Doc: Issue 4059: Document MIDI mapping and MIDI effects (issue 249980043 by tdanielsmu...@googlemail.com)

2015-07-07 Thread David Kastrup
Keith OHara k-ohara5...@oco.net writes: That programmer who added the code didn't know about Lilypond's engraver/performer method of routing events and property-changes to output, and didn't know much about midi, so the data flow doesn't make much sense in the context of Lilypond and MIDI.

Re: Doc: Issue 4059: Document MIDI mapping and MIDI effects (issue 249980043 by tdanielsmu...@googlemail.com)

2015-07-06 Thread tdanielsmusic
Reviewers: Keith, https://codereview.appspot.com/249980043/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/249980043/diff/1/Documentation/notation/input.itely#newcode3279 Documentation/notation/input.itely:3279:

Re: Doc: Issue 4059: Document MIDI mapping and MIDI effects (issue 249980043 by tdanielsmu...@googlemail.com)

2015-07-06 Thread Keith OHara
On Mon, 06 Jul 2015 15:19:20 -0700, tdanielsmu...@googlemail.com wrote: Setting midiChannelMapping to 'voice often prevents the context properties from having effect. Doesn't the paragraph under 'voice above explain explicitly what happens? That seems better than the rather vague often

Doc: Issue 4059: Document MIDI mapping and MIDI effects (issue 249980043 by tdanielsmu...@googlemail.com)

2015-07-03 Thread k-ohara5a5a
Sorry I'm late. You might still slip in a correction, or just remove mention of midiChannelMapping='voice since we haven't found a use for it. https://codereview.appspot.com/249980043/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right):