Re: Doc: NR add predefined paper sizes to appendix (issue 5783075)

2012-03-18 Thread tdanielsmusic
LGTM, James, apart from a couple of nitpicks (but I didn't check the sizes :) Might be worth raising an issue about the lack of an automated appendix once this is pushed. Thanks Trevor http://codereview.appspot.com/5783075/diff/3001/Documentation/notation/spacing.itely File

Re: Doc: NR add predefined paper sizes to appendix (issue 5783075)

2012-03-18 Thread pkx166h
http://codereview.appspot.com/5783075/diff/3001/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): http://codereview.appspot.com/5783075/diff/3001/Documentation/notation/spacing.itely#newcode211 Documentation/notation/spacing.itely:211: @code{set-paper-size}

Re: Doc: NR add predefined paper sizes to appendix (issue 5783075)

2012-03-17 Thread pkx166h
Reviewers: dak, Message: My new ammended comment in the git format patch seems to not have been included with git-cl --snip-- Issue 2391 Copied predefined paper size entries from scm/paper.scm as a seperate appendix entry in order to better document predefined paper sizes. Also revamped

Doc: NR add predefined paper sizes to appendix (issue 5783075)

2012-03-11 Thread dak
http://codereview.appspot.com/5783075/diff/1/Documentation/notation/notation-appendices.itely File Documentation/notation/notation-appendices.itely (right): http://codereview.appspot.com/5783075/diff/1/Documentation/notation/notation-appendices.itely#newcode450