Re: Doc: add markup objects overview (issue 357930043 by v.villen...@gmail.com)

2019-02-01 Thread v . villenave
On 2019/01/28 20:07:19, Valentin Villenave wrote: if nobody has any further objection, I suggest pushing it onto the countdown list… Pushed as https://git.savannah.gnu.org/cgit/lilypond.git/commit/?h=staging&id=e4996ee891128a07256e95f3c8321134eb7dd499 Thanks! https://codereview.appspot.com/35

Re: Doc: add markup objects overview (issue 357930043 by v.villen...@gmail.com)

2019-01-28 Thread v . villenave
On 2019/01/24 21:11:20, Valentin Villenave wrote: Address Werner’s suggestions. This is a rather trivial amendment, so if nobody has any further objection, I suggesting pushing it onto the countdown list… https://codereview.appspot.com/357930043/ ___

Re: Doc: add markup objects overview (issue 357930043 by v.villen...@gmail.com)

2019-01-24 Thread v . villenave
Thanks a lot Werner! You caught quite a few things I should have dealt with more rigorously. https://codereview.appspot.com/357930043/diff/20001/Documentation/notation/text.itely File Documentation/notation/text.itely (right): https://codereview.appspot.com/357930043/diff/20001/Documentation/n

Re: Doc: add markup objects overview (issue 357930043 by v.villen...@gmail.com)

2019-01-20 Thread lemzwerg
LGTM, with some minor issues. Thanks! https://codereview.appspot.com/357930043/diff/20001/Documentation/notation/text.itely File Documentation/notation/text.itely (right): https://codereview.appspot.com/357930043/diff/20001/Documentation/notation/text.itely#newcode50 Documentation/notation/tex