Re: Document Kievan ligature engraver (issue 7382060)

2013-02-28 Thread graham
LGTM https://codereview.appspot.com/7382060/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Document Kievan ligature engraver (issue 7382060)

2013-02-28 Thread Trevor Daniels
aleksandr.andreev wrote Wednesday, February 27, 2013 2:49 PM > I think it makes sense to push this patch first and then I will upload > another patch that changes the syntax across the manual. That way it is > cleaner in the commit history. Fine by me. > There is also Issue 1287. I could try t

Re: Document Kievan ligature engraver (issue 7382060)

2013-02-27 Thread aleksandr . andreev
On 2013/02/27 09:24:07, Trevor Daniels wrote: On 2013/02/27 03:26:11, aleksandr.andreev wrote: > Looking at the sections on Mensural and Gregorian notations, it looks like the > \transpose c c' syntax is used quite often there. On the other hand, the > \relative syntax is used in the "scenari

Re: Document Kievan ligature engraver (issue 7382060)

2013-02-27 Thread tdanielsmusic
On 2013/02/27 03:26:11, aleksandr.andreev wrote: Looking at the sections on Mensural and Gregorian notations, it looks like the \transpose c c' syntax is used quite often there. On the other hand, the \relative syntax is used in the "scenarios and solutions" section. I don't mind changing t

Re: Document Kievan ligature engraver (issue 7382060)

2013-02-26 Thread aleksandr . andreev
On 2013/02/26 16:07:33, Trevor Daniels wrote: One suggested change; otherwise LGTM. Trevor https://codereview.appspot.com/7382060/diff/1/Documentation/notation/ancient.itely File Documentation/notation/ancient.itely (right): https://codereview.appspot.com/7382060/diff/1/Documentation/no

Re: Document Kievan ligature engraver (issue 7382060)

2013-02-26 Thread tdanielsmusic
One suggested change; otherwise LGTM. Trevor https://codereview.appspot.com/7382060/diff/1/Documentation/notation/ancient.itely File Documentation/notation/ancient.itely (right): https://codereview.appspot.com/7382060/diff/1/Documentation/notation/ancient.itely#newcode2607 Documentation/notat

Document Kievan ligature engraver (issue 7382060)

2013-02-25 Thread aleksandr . andreev
Reviewers: , Message: Please review. Description: Document Kievan ligature engraver Adds subsection about Kievan ligatures to ancient notation section of notation manual. Please review this at https://codereview.appspot.com/7382060/ Affected files: M Documentation/notation/ancient.itely I