On 2013/03/24 16:39:03, Trevor Daniels wrote:
Please choose between patchsets 4 and 5.
I prefer 5. The warning does no harm if it is
never triggered, but is there in case some future
change elsewhere assumes a non-empty stencil will
be aligned even if its extent is empty. It is
relevant
I was a little concerned that problems might
result when a non-empty stencil was given an
empty extent, but as this passes all tests it
looks like this fear was unfounded.
So LGTM apart from a nitpick.
Trevor
https://codereview.appspot.com/7533046/diff/15001/lily/self-alignment-interface.cc
On 2013/03/24 12:37:14, Trevor Daniels wrote:
I was a little concerned that problems might
result when a non-empty stencil was given an
empty extent, but as this passes all tests it
looks like this fear was unfounded.
I don't think your fear is unfounded: there just does not seem to be any
On 2013/03/24 12:45:38, dak wrote:
On 2013/03/24 12:37:14, Trevor Daniels wrote:
I was a little concerned that problems might
result when a non-empty stencil was given an
empty extent, but as this passes all tests it
looks like this fear was unfounded.
I don't think your fear is
On 2013/03/24 12:45:38, dak wrote:
On 2013/03/24 12:37:14, Trevor Daniels wrote:
I was a little concerned that problems might
result when a non-empty stencil was given an
empty extent, but as this passes all tests it
looks like this fear was unfounded.
I don't think your fear is
Patchset 5 warns the user when the extent is empty and stencil isn't.
However, i'm not sure if we should warn about such situations at all;
i haven't found any similar warnings in the codebase. Also, detecting
non-empty stencils with empty extents is quite unrelated to alignment
code.
Please
