Re: EXPERIMENTAL: put a reminder of the mm rest on the last page at the top. (issue 553400043 by hanw...@gmail.com)

2020-02-19 Thread hanwenn
abandoning; implemented as user defined reminder instead https://codereview.appspot.com/553400043/

Re: EXPERIMENTAL: put a reminder of the mm rest on the last page at the top. (issue 553400043 by hanw...@gmail.com)

2020-01-25 Thread Han-Wen Nienhuys
On Sat, Jan 25, 2020 at 3:57 PM wrote: > > I'm not asking for anyone to review. It's context to the other change > about > > multi-measure-rests. > > OIC. An MMR reminder sounds interesting. Does the problem tie in with > others like repeating the current chord name after a page break? > > https

Re: EXPERIMENTAL: put a reminder of the mm rest on the last page at the top. (issue 553400043 by hanw...@gmail.com)

2020-01-25 Thread nine . fierce . ballads
On 2020/01/24 19:29:56, hanwenn wrote: > I'm not asking for anyone to review. It's context to the other change about > multi-measure-rests. OIC. An MMR reminder sounds interesting. Does the problem tie in with others like repeating the current chord name after a page break? https://codereview.

Re: EXPERIMENTAL: put a reminder of the mm rest on the last page at the top. (issue 553400043 by hanw...@gmail.com)

2020-01-24 Thread hanwenn
Reviewers: Dan Eble, Message: I'm not asking for anyone to review. It's context to the other change about multi-measure-rests. It's also a demonstration of why I want to get away from rietveld, because it doesn't handle dependent changes. Description: EXPERIMENTAL: put a reminder of the mm rest

EXPERIMENTAL: put a reminder of the mm rest on the last page at the top. (issue 553400043 by hanw...@gmail.com)

2020-01-24 Thread nine . fierce . ballads
There's some stuff here that I already spent time reviewing, and having to sift through it to find the new stuff is asking a lot. Would you mind narrowing this review down to the code for the feature itself? https://codereview.appspot.com/553400043/