All changes implemented save ly:make-event-class, which I wouldn't want to
touch in this issue as it is a public function and thus may cause renaming
issues in both the repository and people's scores. I wouldn't mind opening
a separate issue for it, but I'm not sure how one goes about registering
On 18 August 2010 23:12, Mike Solomon wrote:
> Should be good to go!
> ~Mike
> (issue 1867050)
Thank, that seems to have fixed it.
Cheers,
Neil
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Hi Mike,
Here are the comments I made copied from Rietveld:
+#(ly:define-event-class 'scheme-text-span-event
+'(scheme-text-span-event
+ span-event
It would be great if the hierarchy could be completed automatically
rather than having to specify e
Should be good to go!
~Mike
(issue 1867050)
On 8/14/10 10:20 AM, "Neil Puttock" wrote:
> On 13 August 2010 23:31, Neil Puttock wrote:
>
>> I'll see if it works tomorrow, otherwise I'll copy them here.
>
> Still no joy. It looks like the base file for the regtest didn't get
> uploaded properl
On 13 August 2010 23:31, Neil Puttock wrote:
> I'll see if it works tomorrow, otherwise I'll copy them here.
Still no joy. It looks like the base file for the regtest didn't get
uploaded properly (according to this bug report:
http://code.google.com/p/rietveld/issues/detail?id=159).
Could you
On 13 August 2010 09:12, Mike Solomon wrote:
> Done - thank you for the suggestion. Attached is the patch series, which
> can also be found on http://codereview.appspot.com/1867050 . Thank you!
Looks good. I've added quite a few comments, but just got a sever
error trying to publish them. :(
On 8/12/10 7:20 PM, "Trevor Daniels" wrote:
>
> Mike Solomon wrote Thursday, August 12, 2010 10:16 AM
>
>>I added an extra symbol check to my event class patch:
>>
>> http://codereview.appspot.com/1867050
>>
>> Also, I have a regression test that creates a spanner engraver
>> from the
>>
Mike Solomon wrote Thursday, August 12, 2010 10:16 AM
I added an extra symbol check to my event class patch:
http://codereview.appspot.com/1867050
Also, I have a regression test that creates a spanner engraver
from the
scheme end using this function (said regtest could also be turned
int
Hey all,
I added an extra symbol check to my event class patch:
http://codereview.appspot.com/1867050
Also, I have a regression test that creates a spanner engraver from the
scheme end using this function (said regtest could also be turned into a bit
of documentation for the contributor's gui
