Re: Fix 1464 (segfault with R1 and metronome) (issue3858041)

2011-01-07 Thread percival . music . ca
I've done two regtest checks, and it all seems fine, so I've pushed it. http://codereview.appspot.com/3858041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix 1464 (segfault with R1 and metronome) (issue3858041)

2011-01-02 Thread n . puttock
LGTM, but I'd rather we didn't set the parent twice (at least in the default case where BreakAlignment is acknowledged; obviously once the engraver's moved, this acknowledger never gets called). Cheers, Neil

Re: Fix 1464 (segfault with R1 and metronome) (issue3858041)

2011-01-02 Thread percival . music . ca
I've fixed the problems Neil identified in the regtest, but it's still setting the parent twice, and I'm aware that there's still discussion between Joe and Matthias about this patch. I'm mainly putting this on reitveld in case people want to discuss it by adding comments to places, rather than

Fix 1464 (segfault with R1 and metronome) (issue3858041)

2011-01-01 Thread percival . music . ca
Reviewers: , Message: Fixes a segfault, passes the regtest comparison, code by Matthias Kilian. Description: Fix 1464 (segfault with R1 and metronome) This code came from Mathias Kilian. Please review this at http://codereview.appspot.com/3858041/ Affected files: A