Re: Fix 155: parentheses include accidentals and dots. (issue 5047048)

2011-09-27 Thread Carl . D . Sorensen
Preprocessing graphical objects... +programming error: no pure Y common refpoint +continuing, cross fingers +programming error: no pure Y common refpoint +continuing, cross fingers Calculating line breaks... Looks to me like friends is not defined for TabNoteHead grobs, and perhaps should

Re: Fix 155: parentheses include accidentals and dots. (issue 5047048)

2011-09-27 Thread pkx166h
Passes make but I get some reg test 'crossing fingers' messages --snip-- /home/jlowe/lilypond-git/input/regression/tablature-grace-notes.log @@ -2,6 +2,10 @@ Renaming input to: `/home/jlowe/lilypond-git/input/regression/tablature-grace-notes.ly' Interpreting music... Preprocessing grap

Re: Fix 155: parentheses include accidentals and dots. (issue 5047048)

2011-09-20 Thread mtsolo
LGTM. http://codereview.appspot.com/5047048/diff/8001/scm/output-lib.scm File scm/output-lib.scm (right): http://codereview.appspot.com/5047048/diff/8001/scm/output-lib.scm#newcode626 scm/output-lib.scm:626: (foo (display "calculating pure y extent")) ¿Qué es? http://codereview.appspot.com/504

Re: Fix 155: parentheses include accidentals and dots. (issue 5047048)

2011-09-19 Thread Joe Neeman
Thanks, I've re-uploaded it and it seems to work now. Joe On Mon, Sep 19, 2011 at 10:19 PM, wrote: > Hey Joe, > > For some reason, the scm files say "Upload in progress." > This may come from a MIME type issue for scm files (upload.py doesn't > know that scm files correspond to Scheme language

Re: Fix 155: parentheses include accidentals and dots. (issue 5047048)

2011-09-19 Thread mtsolo
Hey Joe, For some reason, the scm files say "Upload in progress." This may come from a MIME type issue for scm files (upload.py doesn't know that scm files correspond to Scheme language files). I forget how to fix this, but I know the fix has been suggested somewhere on the list. Cheers, MS ht

Re: Fix 155: parentheses include accidentals and dots. (issue 5047048)

2011-09-18 Thread Carl Sorensen
On 9/18/11 2:28 PM, "joenee...@gmail.com" wrote: > Reviewers: Bertrand Bordage, > > Message: > On 2011/09/17 17:31:15, Bertrand Bordage wrote: >> Hi Joe, > >> At last, a fix for that! >> But this looks unfinished. Are you working on a solution that would > avoid >> having to specify the X-exte

Re: Fix 155: parentheses include accidentals and dots. (issue 5047048)

2011-09-18 Thread joeneeman
Reviewers: Bertrand Bordage, Message: On 2011/09/17 17:31:15, Bertrand Bordage wrote: Hi Joe, At last, a fix for that! But this looks unfinished. Are you working on a solution that would avoid having to specify the X-extent? That isn't actually mentioned in the issue report, but ok :)

Fix 155: parentheses include accidentals and dots. (issue 5047048)

2011-09-17 Thread bordage . bertrand
Hi Joe, At last, a fix for that! But this looks unfinished. Are you working on a solution that would avoid having to specify the X-extent? A fix that calculates the font size of the ParenthesesItem according to the Y-extent of the parenthesized grobs would also be awesome :) Bertrand http://c