On 2009/12/14 17:15:13, Ian Hulin wrote:
Version numbers sorted, also formatting of music in
hara-kiri-drumstaff and
hara-kiri-tabstaff.
Regression tests re-run locally.
LGTM.
You just need to rebase against master to get rid of the reverts in
engraver-init.ly, then it'll be ready for pus
Version numbers sorted, also formatting of music in hara-kiri-drumstaff
and hara-kiri-tabstaff.
Regression tests re-run locally.
Cheers,
Ian
http://codereview.appspot.com/165096/diff/3015/1022
File ly/engraver-init.ly (left):
http://codereview.appspot.com/165096/diff/3015/1022#oldcode144
ly/e
On 2009/12/12 00:12:16, Ian Hulin wrote:
I've implemented Neil's comments, re-run regression tests locally and
uploaded
amended patches to Rietveld.
Thanks!
I think this should be ready to push now.
Nearly there:
You're playing catch-up with the \version strings. :)
Both hara-kiri-rhyt
Hi,
I've implemented Neil's comments, re-run regression tests locally and
uploaded amended patches to Rietveld.
I think this should be ready to push now.
Cheers,
Ian
http://codereview.appspot.com/165096/diff/1/2
File input/regression/hara-kiri-drums.ly (right):
http://codereview.appspot.com/
Hi Neil,
n.putt...@gmail.com wrote:
Hi Ian,
LGTM, apart from some formatting issues and a few incorrect \version
numbers.
Can you sort out the naming of the new regression tests? For
consistency with the existing test, I'd advise amending them as follows:
hara-kiri-drumstaff.ly
hara-kiri-rhy
Hi Ian,
LGTM, apart from some formatting issues and a few incorrect \version
numbers.
Can you sort out the naming of the new regression tests? For
consistency with the existing test, I'd advise amending them as follows:
hara-kiri-drumstaff.ly
hara-kiri-rhythmicstaff.ly
hara-kiri-tabstaff.ly
C
Reviewers: ,
Message:
Patch for Tracker 918 available on Rietveld - Issue 165096. This
includes updated/enhanced regression tests.
Description:
Fix Tracker 918, Add extra RemoveEmpty*StaffContext functions to support
"Frenched" scores
with DrumStaff, TabStaff and RhythmicStaff staves.
Add new d
