Re: Fix dashed line errors (issue 320320043 by david.nales...@gmail.com)

2017-03-07 Thread lemzwerg
LGTM. https://codereview.appspot.com/320320043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix dashed line errors (issue 320320043 by david.nales...@gmail.com)

2017-03-07 Thread Urs Liska
I currently can't compile so I can't test the patch, and I can only assess (1) from reading the code. But it's good to fix this. It's a glitch but nevertheless "feels" awkward when tweaking a score. Urs Am 07.03.2017 um 05:46 schrieb david.nales...@gmail.com: > Reviewers: , > > Message: >

Fix dashed line errors (issue 320320043 by david.nales...@gmail.com)

2017-03-06 Thread david . nalesnik
Reviewers: , Message: Please review. Thanks! Description: Fix dashed line errors There are two errors in lily/line-interface.cc which cause dashed lines to be drawn inaccurately. (1) Line-thickness is improperly subtracted from the "off" value in Line_interface::make_dashed_line. This was