Re: Fix determine-frets so that it preserves note order (issue4518045)

2011-05-25 Thread Carl . D . Sorensen
On 2011/05/26 03:26:32, Keith wrote: `make check` was crashing on an unbound variable 'note'. Given line 345 above the fix was so obvious that I just pushed it. Thanks for the fix. I had found that fix as well, and was getting ready to push it. But there's still another problem. Right no

Re: Fix determine-frets so that it preserves note order (issue4518045)

2011-05-25 Thread k-ohara5a5a
http://codereview.appspot.com/4518045/diff/1/scm/translation-functions.scm File scm/translation-functions.scm (right): http://codereview.appspot.com/4518045/diff/1/scm/translation-functions.scm#newcode351 scm/translation-functions.scm:351: (note-pitch note) string)) (car pitch-entry)

Re: Fix determine-frets so that it preserves note order (issue4518045)

2011-05-09 Thread n . puttock
http://codereview.appspot.com/4518045/diff/1/scm/translation-functions.scm File scm/translation-functions.scm (right): http://codereview.appspot.com/4518045/diff/1/scm/translation-functions.scm#newcode280 scm/translation-functions.scm:280: (define free-strings (map 1+ (iota (length tuning co

Re: Fix determine-frets so that it preserves note order (issue4518045)

2011-05-09 Thread Neil Puttock
On 9 May 2011 19:44, Carl Sorensen wrote: > There's no guarantee that the notes will be in decreasing string number > order. > > That's the general case, but it's not required. > > In absolute mode I can write a C major chord as > > > > or > > > > and as far as I know, we have no requirement th

Re: Fix determine-frets so that it preserves note order (issue4518045)

2011-05-09 Thread Carl Sorensen
On 5/9/11 12:34 PM, "n.putt...@gmail.com" wrote: > Hi Carl, > > LGTM, apart from some indentation issues. > > One question for you though: do you think the refactoring is an > improvement on the current code? You could for example achieve the same > result with the following: > > (sor

Re: Fix determine-frets so that it preserves note order (issue4518045)

2011-05-09 Thread n . puttock
Hi Carl, LGTM, apart from some indentation issues. One question for you though: do you think the refactoring is an improvement on the current code? You could for example achieve the same result with the following: (sort string-fret-fingering-tuples (lambda (a b) (> (car a) (car b

Fix determine-frets so that it preserves note order (issue4518045)

2011-05-09 Thread Carl . D . Sorensen
Reviewers: MikeSol, Message: In response to Mike's request, I've fixed the problem in determine-frets that sometimes changed the order of the notes in the chord. This keeps the glissando between the same notes in the TabStaff as in the Staff. I've made enough changes that I'd like to get a revi