Re: Fix issue 4040: Dots ignoring shifted ledger lines (issue 220090043 by paulwmor...@gmail.com)

2015-03-28 Thread pkx166h
author Paul Morris Fri, 20 Mar 2015 04:27:20 + (00:27 -0400) committer James Lowe Sat, 28 Mar 2015 16:40:48 + (16:40 +) commit ccb42361aa4ad49c07d5c76b1feab3d6647dc159 and author Paul Morris Fri, 20 Mar 2015 04:34:31 + (00:34

Re: Fix issue 4040: Dots ignoring shifted ledger lines (issue 220090043 by paulwmor...@gmail.com)

2015-03-28 Thread pkx166h
Patch counted down - please push (make sure you fix the trailing white spaces) https://codereview.appspot.com/220090043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix issue 4040: Dots ignoring shifted ledger lines (issue 220090043 by paulwmor...@gmail.com)

2015-03-27 Thread pkx166h
On 2015/03/27 04:50:36, pwm wrote: On 2015/03/26 17:21:38, david.nalesnik wrote: > Aside from whitespace issue, LGTM. I assume this could be fixed when pushing, > and there's no need to put this back on review? Thanks, that works for me, but someone just let me know if I should submit ano

Re: Fix issue 4040: Dots ignoring shifted ledger lines (issue 220090043 by paulwmor...@gmail.com)

2015-03-26 Thread paulwmorris
On 2015/03/26 17:21:38, david.nalesnik wrote: Aside from whitespace issue, LGTM. I assume this could be fixed when pushing, and there's no need to put this back on review? Thanks, that works for me, but someone just let me know if I should submit another patch for review for this. https://c

Re: Fix issue 4040: Dots ignoring shifted ledger lines (issue 220090043 by paulwmor...@gmail.com)

2015-03-26 Thread paulwmorris
https://codereview.appspot.com/220090043/diff/1/input/regression/staff-ledger-positions-dotted-notes.ly File input/regression/staff-ledger-positions-dotted-notes.ly (right): https://codereview.appspot.com/220090043/diff/1/input/regression/staff-ledger-positions-dotted-notes.ly#newcode2 input/reg

Re: Fix issue 4040: Dots ignoring shifted ledger lines (issue 220090043 by paulwmor...@gmail.com)

2015-03-26 Thread david . nalesnik
Aside from whitespace issue, LGTM. I assume this could be fixed when pushing, and there's no need to put this back on review? https://codereview.appspot.com/220090043/diff/1/input/regression/staff-ledger-positions-dotted-notes.ly File input/regression/staff-ledger-positions-dotted-notes.ly (rig

Re: Fix issue 4040: Dots ignoring shifted ledger lines (issue 220090043 by paulwmor...@gmail.com)

2015-03-25 Thread pkx166h
Patch on countdown for March 28th https://codereview.appspot.com/220090043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix issue 4040: Dots ignoring shifted ledger lines (issue 220090043 by paulwmor...@gmail.com)

2015-03-24 Thread Paul Morris
I added some more details in a tracker comment: https://code.google.com/p/lilypond/issues/detail?id=4040#c5 -Paul -- View this message in context: http://lilypond.1069038.n5.nabble.com/Fix-issue-4040-Dots-ignoring-shifted-ledger-lines-issue-220090043-by-paulwmorris-gmail-com-tp173514p173576.h

Fix issue 4040: Dots ignoring shifted ledger lines (issue 220090043 by paulwmor...@gmail.com)

2015-03-22 Thread paulwmorris
Reviewers: , Message: Please review, thanks! -Paul Description: Fix issue 4040: Dots ignoring shifted ledger lines includes the following two commits: add test staff-ledger-positions-dotted-notes.ly tests positioning of dots on dotted notes with custom ledger line positions (issue 4040) sta