Just skimming the code: LGTM
https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-distance.py
File scripts/build/output-distance.py (right):
https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-distance.py#newcode66
scripts/build/output-distance.py
On 2020/03/14 21:58:52, lemzwerg wrote:
> Just skimming the code: LGTM
>
>
https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-distance.py
> File scripts/build/output-distance.py (right):
>
>
https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-dis
> Are there still systems that run without bash that we care about?
I guess all BSD variants might miss bash since it is evil, evil GNU
software.
https://codereview.appspot.com/569540043/
hanw...@gmail.com writes:
> On 2020/03/14 21:58:52, lemzwerg wrote:
>> Just skimming the code: LGTM
>>
>>
> https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-distance.py
>> File scripts/build/output-distance.py (right):
>>
>>
> https://codereview.appspot.com/569540043/
On Sun, Mar 15, 2020 at 5:10 PM David Kastrup wrote:
>
> hanw...@gmail.com writes:
>
> > On 2020/03/14 21:58:52, lemzwerg wrote:
> >> Just skimming the code: LGTM
> >>
> >>
> > https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-distance.py
> >> File scripts/build/output-d
Han-Wen Nienhuys writes:
> On Sun, Mar 15, 2020 at 5:10 PM David Kastrup wrote:
>>
>> hanw...@gmail.com writes:
>>
>> > On 2020/03/14 21:58:52, lemzwerg wrote:
>> >> Just skimming the code: LGTM
>> >>
>> >>
>> > https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-distanc
On Mar 15, 2020, at 12:21, David Kastrup wrote:
>
> Han-Wen Nienhuys writes:
>> suggests that OSX actually uses bash.
>
> Paywalled site.
The current macOS (10.15.3, "Catalina") sets zsh as the default shell for new
users. bash is still provided.
$ zsh --version
zsh 5.7.1 (x86_64-ap
commit fd4021a3725cda2fe41079af8208a629dda39f1a
Author: Han-Wen Nienhuys
Date: Sat Mar 14 00:01:03 2020 +0100
Fix output-distance tests
https://codereview.appspot.com/569540043/