Re: Fixes figuredBassCenterContinuations. (issue4868046)

2011-08-12 Thread Bertrand Bordage
This was introduced in one of Han-Wen's commits : 7d7d33f3f1c6c45aaf3fd1e5c68b0b75a1be248d At that time there was no property to center figures, that's probably why Han-Wen added this condition (I know, this doesn't explain well its presence). ___ lilypon

Re: Fixes figuredBassCenterContinuations. (issue4868046)

2011-08-12 Thread reinhold . kainhofer
LGTM. That check has been there since time immemorial. I have sometimes wondered, too, but never bothered to change anything (since I don't use continuation combining). http://codereview.appspot.com/4868046/diff/4/lily/figured-bass-engraver.cc File lily/figured-bass-engraver.cc (left): http://c

Fixes figuredBassCenterContinuations. (issue4868046)

2011-08-12 Thread bordage . bertrand
Reviewers: , Message: figuredBassCenterContinuations fails to merge continuation lines on if a figure is composed of three or more figures. This tiny patch fixes that. Bertrand Description: Fixes figuredBassCenterContinuations. Please review this at http://codereview.appspot.com/4868046/ Aff