Reviewers: ,
Message:
Cheers,
MS
Description:
Fixes issue 1628.
Please review this at http://codereview.appspot.com/4876051/
Affected files:
M lily/include/slur-scoring.hh
M lily/include/slur.hh
M lily/new-fingering-engraver.cc
M lily/slur-configuration.cc
M lily/slur-engraver.cc
M
So far, so good.
Would you include the corresponding changes to
phrasing-slur-engraver.cc (mostly a duplication of slur-engraver.cc) in
your next patch set?
http://codereview.appspot.com/4876051/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Your patch is doing much more than address issue 1628. Can you do
just the change to the engraver to close issue 1628? Any ensuing
collisions should be made into a new issue.
Are you sure exclude_extra_objects_outside_x_range() is really needed?
We already have
Real x = info.extents_
On Aug 16, 2011, at 1:06 PM, Han-Wen Nienhuys wrote:
> Your patch is doing much more than address issue 1628. Can you do
> just the change to the engraver to close issue 1628? Any ensuing
> collisions should be made into a new issue.
>
OK. The reason that I added all that extra stuff was for
New patchset uploaded w/ minimal changes made (just the engravers).
http://codereview.appspot.com/4876051/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM
Now string numbers move around slurs as well.
That didn't work in the old patch, nor in 2.14.
The old regtest string-number-around-slur.ly avoided collisions only by
accident. Different pitches would cause collisions with the string
numbers, but after this patch they really move #'around t
Pushed as 29d1121d260318ed07f152c346a1a69e5dadb69d.
Keith: I ultimately decided not to change the textLengthOn in the
regtest so that the test can test if objects from the
new-fingering-engraver have their callbacks chained in the correct
order. Even if this leads to an aesthetically inferior re
