Reviewers: ,
Message:
Hey all,
A one-line-deletion patch to fix 1881.
I think the re-introduction of length and stem-begin-position both made
this line obsolete and triggered cyclic dependencies.
I'm still not sure why these dependencies resulted in changed visual
output, but this patch seems
LGTM.
BTW, I have a few queries about stem::length:
76 (let* ((d (ly:grob-property grob 'direction))
You don't use 'direction; is it still necessary to get it to trigger
other calculations?
79 (beam (ly:grob-object grob 'beam)))
Why do you need to access 'beam? AFAICT, the
On Sep 17, 2011, at 11:07 AM, n.putt...@gmail.com wrote:
LGTM.
BTW, I have a few queries about stem::length:
76 (let* ((d (ly:grob-property grob 'direction))
You don't use 'direction; is it still necessary to get it to trigger
other calculations?
I doubt it - it's likely
Mike,
On Sat, Sep 17, 2011 at 10:27 AM, m...@apollinemike.com
m...@apollinemike.com wrote:
On Sep 17, 2011, at 11:07 AM, n.putt...@gmail.com wrote:
LGTM.
BTW, I have a few queries about stem::length:
76 (let* ((d (ly:grob-property grob 'direction))
You don't use 'direction; is it still
On Sep 17, 2011, at 1:06 PM, Peekay Ex wrote:
Mike,
On Sat, Sep 17, 2011 at 10:27 AM, m...@apollinemike.com
m...@apollinemike.com wrote:
On Sep 17, 2011, at 11:07 AM, n.putt...@gmail.com wrote:
LGTM.
BTW, I have a few queries about stem::length:
76 (let* ((d (ly:grob-property
On 17 September 2011 12:16, m...@apollinemike.com m...@apollinemike.com wrote:
They should be applied separately - 5038042 fixes 1881, and 5057041 prunes
down bloated code. There is a chance that 5057041 is effected by 5038042 (I
haven't tested them together yet) though I doubt it. After
On Sep 17, 2011, at 1:28 PM, Neil Puttock wrote:
On 17 September 2011 12:16, m...@apollinemike.com m...@apollinemike.com
wrote:
They should be applied separately - 5038042 fixes 1881, and 5057041 prunes
down bloated code. There is a chance that 5057041 is effected by 5038042 (I
