Re: Fixes missing images in big website page (issue 4963046)

2011-09-22 Thread Phil Holmes
- Original Message - From: To: ; ; Cc: ; Sent: Wednesday, September 21, 2011 5:08 AM Subject: Re: Fixes missing images in big website page (issue 4963046) LGTM. A quick test showed no problems in make doc. I didn't get pictures in make website, but then I tried make we

Re: Fixes missing images in big website page (issue 4963046)

2011-09-20 Thread percival . music . ca
LGTM. A quick test showed no problems in make doc. I didn't get pictures in make website, but then I tried make website without the patch applied, and I still didn't get pictures... evidently I don't have my desktop set up to create the full website any more. So that's not a reason to distrust

Re: Fixes missing images in big website page (issue 4963046)

2011-09-16 Thread PhilEHolmes
Updated patch which produces a web-big-page with all images included. Please review. Next step after this will be to fix the links in that page. http://codereview.appspot.com/4963046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://list

Re: Fixes missing images in big website page (issue 4963046)

2011-08-30 Thread Graham Percival
On Mon, Aug 29, 2011 at 05:24:51PM +0100, Phil Holmes wrote: > OK. My claim that this is fixed is partly down to the number of > copies of web-big-page.html on the system after a build. It's fixed > in the wrong one, but not fixed in the right one. To get my head > fully around this, I think I n

Re: Fixes missing images in big website page (issue 4963046)

2011-08-29 Thread Phil Holmes
- Original Message - From: "Graham Percival" To: "Phil Holmes" Cc: ; ; ; Sent: Monday, August 29, 2011 2:29 PM Subject: Re: Fixes missing images in big website page (issue 4963046) On Mon, Aug 29, 2011 at 02:00:51PM +0100, Phil Holmes wrote: - Origina

Re: Fixes missing images in big website page (issue 4963046)

2011-08-29 Thread Graham Percival
On Mon, Aug 29, 2011 at 02:00:51PM +0100, Phil Holmes wrote: > - Original Message - From: > To: > Cc: ; > Sent: Monday, August 29, 2011 1:58 PM > Subject: Re: Fixes missing images in big website page (issue 4963046) > > > >I see images, but not ly-example

Re: Fixes missing images in big website page (issue 4963046)

2011-08-29 Thread Phil Holmes
- Original Message - From: To: Cc: ; Sent: Monday, August 29, 2011 1:58 PM Subject: Re: Fixes missing images in big website page (issue 4963046) I see images, but not ly-examples. Are you sure you see ly-examples on your system? http://codereview.appspot.com/4963046/ Is this

Re: Fixes missing images in big website page (issue 4963046)

2011-08-29 Thread percival . music . ca
I see images, but not ly-examples. Are you sure you see ly-examples on your system? http://codereview.appspot.com/4963046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Fixes missing images in big website page (issue 4963046)

2011-08-29 Thread PhilEHolmes
Reviewers: Graham Percival, Message: As requested, an updated code review. Please review. Description: This is an updated patch to put the missing image files back into http://lilypond.org/doc/v2.15/Documentation/web-big-page.html#examples. It adds an extra element to the path to ly-examples (